optimize : put single-quotes around ':' to use the faster "indexOf(char)" method.#5585
Merged
chickenlj merged 1 commit intoapache:masterfrom Feb 1, 2020
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-14
Merged
optimize : put single-quotes around ':' to use the faster "indexOf(char)" method.#5585chickenlj merged 1 commit intoapache:masterfrom ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-14
chickenlj merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-14
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5585 +/- ##
============================================
- Coverage 61.29% 61.18% -0.11%
+ Complexity 424 421 -3
============================================
Files 922 922
Lines 37502 37502
Branches 5431 5431
============================================
- Hits 22985 22947 -38
- Misses 12042 12070 +28
- Partials 2475 2485 +10
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Use faster indexOf method
Brief changelog
1.dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/configurator/parser/ConfigParser.java
Verifying this change
Passed unit tests
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.