Merged
Conversation
…y-protocol-listener
…t, also update service metadata if necessary
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
suggested changes
Jan 7, 2020
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ConsumerModel.java
Outdated
Show resolved
Hide resolved
…y-protocol-listener
…d to re-build router chain
Codecov Report
@@ Coverage Diff @@
## master #5581 +/- ##
============================================
- Coverage 61.12% 61.01% -0.11%
- Complexity 420 424 +4
============================================
Files 923 924 +1
Lines 37614 37660 +46
Branches 5445 5451 +6
============================================
- Hits 22990 22978 -12
- Misses 12135 12178 +43
- Partials 2489 2504 +15
Continue to review full report at Codecov.
|
qinliujie
reviewed
Jan 16, 2020
| return interfaceFromServiceKey(serviceKey) + ":" + versionFromServiceKey(serviceKey); | ||
| } | ||
|
|
||
| public void reRegisterProvider(String newServiceKey, String serviceKey) { |
Contributor
There was a problem hiding this comment.
if newServiceKey equals serviceKey,then ProviderModel would be remove
qinliujie
reviewed
Jan 16, 2020
| public void setRegisteredConsumerUrl(URL registeredConsumerUrl) { | ||
| this.registeredConsumerUrl = registeredConsumerUrl; | ||
| public void setRegisteredConsumerUrl(URL url) { | ||
| if (!shouldSimplified) { |
Contributor
There was a problem hiding this comment.
is it should be if (shouldSimplified)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.