Skip to content

[Dubbo-5560] fix useless null check in ServiceConfig#5580

Merged
chickenlj merged 3 commits intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-12
Feb 1, 2020
Merged

[Dubbo-5560] fix useless null check in ServiceConfig#5580
chickenlj merged 3 commits intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-12

Conversation

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
Copy link
Copy Markdown

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz commented Jan 3, 2020 •
edited
Loading

What is the purpose of the change

fixes #5560

Brief changelog

1.dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java

Verifying this change

Passed unit tests

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 3, 2020 •
edited
Loading

Codecov Report

Merging #5580 into master will decrease coverage by 0.05%.
The diff coverage is 71.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5580      +/-   ##
============================================
- Coverage     61.19%   61.14%   -0.06%     
- Complexity      422      423       +1     
============================================
  Files           922      923       +1     
  Lines         37502    37568      +66     
  Branches       5431     5441      +10     
============================================
+ Hits          22951    22972      +21     
- Misses        12068    12100      +32     
- Partials       2483     2496      +13
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/ConfigInitializer.java 0% <ø> (ø) 0 <0> (?)
...in/java/org/apache/dubbo/rpc/ListenableFilter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...api/src/main/java/org/apache/dubbo/rpc/Filter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/common/BaseServiceMetadata.java 41.17% <ø> (ø) 0 <0> (ø) ⬇️
...n/serialize/kryo/optimized/KryoSerialization2.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/config/ConfigPostProcessor.java 0% <0%> (ø) 0 <0> (?)
...protobuf/support/GenericProtobufSerialization.java 60% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java 54.94% <0%> (-1.24%) 0 <0> (ø)
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 58.24% <100%> (ø) 0 <0> (ø) ⬇️
...java/org/apache/dubbo/rpc/model/ConsumerModel.java 58.13% <100%> (+2.32%) 0 <0> (ø) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47c739...ff957f4. Read the comment docs.

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz changed the title fix useless null check in ServiceConfig [Dubbo-5560] fix useless null check in ServiceConfig Jan 7, 2020
withthewind added 2 commits January 17, 2020 13:41
Merge branch 'master' of https://github.com/apache/dubbo into patch-12
ff957f4 
� Conflicts:
�	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Merge branch 'master' of https://github.com/apache/dubbo into patch-12
3c99b00 
� Conflicts:
�	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
@chickenlj chickenlj merged commit 11fd999 into apache:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Useless null check

4 participants

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz @codecov-io @htynkn @chickenlj