Skip to content

remove duplicate code in UrlUtils#parseURL#5577

Merged
chickenlj merged 1 commit intoapache:masterfrom
GungnirLaevatain:polish
Feb 9, 2020
Merged

remove duplicate code in UrlUtils#parseURL#5577
chickenlj merged 1 commit intoapache:masterfrom
GungnirLaevatain:polish

Conversation

@GungnirLaevatain
Copy link
Copy Markdown
Contributor

@GungnirLaevatain GungnirLaevatain commented Jan 3, 2020

What is the purpose of the change

defaultProtocol won't be empty, because of this

Brief changelog

org.apache.dubbo.common.utils.UrlUtils

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 3, 2020

Codecov Report

Merging #5577 into master will decrease coverage by 0.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5577      +/-   ##
============================================
- Coverage     61.29%   61.18%   -0.11%     
+ Complexity      424      421       -3     
============================================
  Files           922      922              
  Lines         37502    37502              
  Branches       5431     5431              
============================================
- Hits          22985    22944      -41     
- Misses        12042    12072      +30     
- Partials       2475     2486      +11
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/common/utils/UrlUtils.java 73.92% <66.66%> (ø) 0 <0> (ø) ⬇️
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 59.09% <0%> (-9.1%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0%> (-8.48%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (-8.34%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-7.96%) 19% <0%> (-2%)
...dubbo/remoting/exchange/support/DefaultFuture.java 79.27% <0%> (-7.21%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5dc6e...8950951. Read the comment docs.

@chickenlj chickenlj merged commit 74e2d68 into apache:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GungnirLaevatain @codecov-io @chickenlj