Skip to content

Fix document comments in code blocks to multi-line comments#5573

Merged
chickenlj merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-6
Feb 9, 2020
Merged

Fix document comments in code blocks to multi-line comments#5573
chickenlj merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-6

Conversation

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
Copy link
Copy Markdown

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz commented Jan 1, 2020

What is the purpose of the change

Comments in code blocks should be multi-line comments, not documentation comments

Brief changelog

1.dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java

Verifying this change

Passed unit tests

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 1, 2020

Codecov Report

Merging #5573 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5573      +/-   ##
============================================
- Coverage     61.24%   61.14%   -0.11%     
+ Complexity      425      423       -2     
============================================
  Files           922      922              
  Lines         37504    37504              
  Branches       5432     5432              
============================================
- Hits          22971    22932      -39     
- Misses        12053    12084      +31     
- Partials       2480     2488       +8
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 63.77% <ø> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 30.76% <0%> (-15.39%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 59.09% <0%> (-9.1%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0%> (-6.94%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 59.32% <0%> (-6.78%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0%> (-5.67%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0%> (-4.55%) 20% <0%> (-1%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f1fad...98f0075. Read the comment docs.

@chickenlj chickenlj merged commit cf0af06 into apache:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz @codecov-io @chickenlj