Skip to content

[Dubbo-2992] enhance the java doc of dubbo-common module.#5572

Merged
chickenlj merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-5
Feb 1, 2020
Merged

[Dubbo-2992] enhance the java doc of dubbo-common module.#5572
chickenlj merged 1 commit intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:patch-5

Conversation

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
Copy link
Copy Markdown

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz commented Jan 1, 2020

What is the purpose of the change

#2992

Brief changelog

1.dubbo-common/src/main/java/org/apache/dubbo/common/utils/CollectionUtils.java

Verifying this change

Passed unit test

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz changed the title enhance the java doc of dubbo-common module. [Dubbo-2992] enhance the java doc of dubbo-common module. Jan 1, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 2, 2020

Codecov Report

Merging #5572 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5572      +/-   ##
============================================
- Coverage     61.26%   61.22%   -0.04%     
+ Complexity      425      422       -3     
============================================
  Files           922      922              
  Lines         37504    37504              
  Branches       5432     5432              
============================================
- Hits          22975    22962      -13     
- Misses        12047    12056       +9     
- Partials       2482     2486       +4
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/common/utils/CollectionUtils.java 89.09% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0%> (-5.67%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0%> (-4.55%) 20% <0%> (-1%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0%> (-1.99%) 0% <0%> (ø)
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (-0.29%) 31% <0%> (-1%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.44% <0%> (+0.34%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f1fad...9200d0a. Read the comment docs.

@chickenlj chickenlj merged commit 5e85623 into apache:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz @codecov-io @chickenlj