[Dubbo] Refactoring to remove feature envy#5559
Merged
chickenlj merged 1 commit intoapache:masterfrom Feb 10, 2020
klebertarcisio:alteracao
Merged
[Dubbo] Refactoring to remove feature envy#5559chickenlj merged 1 commit intoapache:masterfrom klebertarcisio:alteracao
chickenlj merged 1 commit intoapache:masterfrom
klebertarcisio:alteracao
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5559 +/- ##
============================================
+ Coverage 61.22% 61.22% +<.01%
- Complexity 422 423 +1
============================================
Files 922 922
Lines 37504 37503 -1
Branches 5432 5430 -2
============================================
+ Hits 22962 22963 +1
+ Misses 12056 12055 -1
+ Partials 2486 2485 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a refactoring opportunity on Dubbo project.
I believe the checkStubAndLocal method can be improved. This method calls ReflectUtils.forName() method 4 times and ConfigUtils class 4 times.
I am proposing a reduction in the amount of calls.
Regards