Skip to content

[Dubbo-perf]: Reduce object allocation for ProtocolUtils.serviceKey(int, Stri…#5525

Merged
chickenlj merged 5 commits intoapache:masterfrom
LinShunKang:performance/reduce_object_allocation_v3
Feb 4, 2020
Merged

[Dubbo-perf]: Reduce object allocation for ProtocolUtils.serviceKey(int, Stri…#5525
chickenlj merged 5 commits intoapache:masterfrom
LinShunKang:performance/reduce_object_allocation_v3

Conversation

@LinShunKang
Copy link
Copy Markdown
Contributor

…ng, String, String)

What is the purpose of the change

Reduce object allocation and memory copy.

Brief changelog

Add a cache for ProtocolUtils.serviceKey(int, String, String, String).

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • [ x Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@LinShunKang
Copy link
Copy Markdown
Contributor Author

@chickenlj PTAL.

@chickenlj chickenlj added this to the 2.7.6 milestone Dec 30, 2019
@chickenlj chickenlj self-assigned this Jan 3, 2020
@chickenlj
Copy link
Copy Markdown
Contributor

LGTM.

@chickenlj
Copy link
Copy Markdown
Contributor

Please, add LICENSE header for newly added files.

@chickenlj
Copy link
Copy Markdown
Contributor

Sorry for bothering you again, this file needs LICENSE too.

dubbo-common/src/test/java/org/apache/dubbo/rpc/support/ProtocolUtilsTest.java

@chickenlj chickenlj merged commit c0d62ed into apache:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants