Skip to content

keep protocol destroy logic unchanged#5517

Merged
chickenlj merged 1 commit intoapache:2.7.5-releasefrom
chickenlj:fix-keep-protocol-destroy-unchanged
Dec 20, 2019
Merged

keep protocol destroy logic unchanged#5517
chickenlj merged 1 commit intoapache:2.7.5-releasefrom
chickenlj:fix-keep-protocol-destroy-unchanged

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj commented Dec 20, 2019

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 20, 2019

Codecov Report

Merging #5517 into 2.7.5-release will decrease coverage by 0.21%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.5-release    #5517      +/-   ##
===================================================
- Coverage            61.18%   60.97%   -0.22%     
+ Complexity             422      420       -2     
===================================================
  Files                  921      921              
  Lines                37590    37586       -4     
  Branches              5465     5450      -15     
===================================================
- Hits                 22999    22917      -82     
- Misses               12084    12151      +67     
- Partials              2507     2518      +11
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 61.76% <ø> (+2.67%) 0 <0> (ø) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 53.48% <66.66%> (-0.46%) 0 <0> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 30.76% <0%> (-38.47%) 0% <0%> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.5% <0%> (-25%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 70.83% <0%> (-16.67%) 0% <0%> (ø)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.38% <0%> (-11.91%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
...dubbo/remoting/exchange/support/DefaultFuture.java 75% <0%> (-7.76%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0%> (-6.94%) 0% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59bc99e...c7643f8. Read the comment docs.

@chickenlj chickenlj merged commit df35785 into apache:2.7.5-release Dec 20, 2019
@chickenlj chickenlj deleted the fix-keep-protocol-destroy-unchanged branch July 3, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chickenlj @codecov-io