add auto-generated Regsitry and Protocol to ConfigManager#5516
Merged
chickenlj merged 3 commits intoapache:2.7.5-releasefrom Dec 20, 2019
Merged
add auto-generated Regsitry and Protocol to ConfigManager#5516chickenlj merged 3 commits intoapache:2.7.5-releasefrom
chickenlj merged 3 commits intoapache:2.7.5-releasefrom
Conversation
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## 2.7.5-release #5516 +/- ##
===================================================
- Coverage 61.08% 61.03% -0.06%
+ Complexity 423 421 -2
===================================================
Files 921 921
Lines 37588 37590 +2
Branches 5465 5465
===================================================
- Hits 22961 22943 -18
- Misses 12120 12137 +17
- Partials 2507 2510 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user does not specify any ProtocolConfig or RegistryConfig, the auto-generated Regsitry and Protocol should be added to ConfigManager