Skip to content

[Dubbo-5479] refactor generic invoke support#5481

Merged
chickenlj merged 1 commit intoapache:masterfrom
hengyunabc:fix_generic
Feb 3, 2020
Merged

[Dubbo-5479] refactor generic invoke support#5481
chickenlj merged 1 commit intoapache:masterfrom
hengyunabc:fix_generic

Conversation

@hengyunabc
Copy link
Copy Markdown
Contributor

@hengyunabc hengyunabc commented Dec 13, 2019

What is the purpose of the change

refactor generic invoke support

Brief changelog

Verifying this change

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Dec 17, 2019

Please check the comments I left on your PR. I would suggest that you submit a new PR and start work from the latest code in the master branch so as to make sure changes are limited to this specific issue #5479.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 19, 2019 •
edited
Loading

Codecov Report

Merging #5481 into master will increase coverage by 0.01%.
The diff coverage is 57.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5481      +/-   ##
============================================
+ Coverage     61.18%   61.19%   +0.01%     
- Complexity      421      422       +1     
============================================
  Files           922      922              
  Lines         37507    37518      +11     
  Branches       5440     5442       +2     
============================================
+ Hits          22947    22959      +12     
+ Misses        12072    12064       -8     
- Partials       2488     2495       +7
Impacted Files Coverage Δ Complexity Δ
...pache/dubbo/config/utils/ReferenceConfigCache.java 63.33% <100%> (ø) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 69.58% <100%> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/GenericImplFilter.java 54.45% <25%> (-3%) 0 <0> (ø)
...g/apache/dubbo/rpc/proxy/AbstractProxyFactory.java 78.94% <77.77%> (+12.28%) 0 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0%> (-11.37%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 78.37% <0%> (-4.51%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0%> (-1%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (ø) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4b2f3...a04de2a. Read the comment docs.

@htynkn htynkn changed the title refactor generic invoke support, fix #5479 [Dubbo-5479] refactor generic invoke support Dec 20, 2019
@htynkn htynkn added the type/bug Bugs to being fixed label Dec 20, 2019
@chickenlj chickenlj added this to the 2.7.6 milestone Dec 30, 2019
@chickenlj chickenlj self-assigned this Jan 3, 2020
@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Feb 1, 2020

Please remove the changes to the demo module, other changes LGTM.

api/dubbo-demo-api-consumer/src/main/java/org/apache/dubbo/demo/consumer/Application.java

@chickenlj chickenlj added type/enhancement and removed type/bug Bugs to being fixed labels Feb 1, 2020
@chickenlj chickenlj merged commit 06249e4 into apache:master Feb 3, 2020
@chickenlj chickenlj mentioned this pull request Feb 9, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chickenlj chickenlj chickenlj approved these changes

Assignees

@chickenlj chickenlj

Labels

None yet

Projects

None yet

Milestone

2.7.6

Development

Successfully merging this pull request may close these issues.

当设置泛化调用时，consumer生成的代理类没有实现应用的接口

4 participants

@hengyunabc @chickenlj @codecov-io @htynkn