Skip to content

Revert "change attachment type from Map<String,String> to Map<String,Object> (#4311)#5455

Merged
chickenlj merged 3 commits intoapache:2.7.5-releasefrom
chickenlj:revert-attachments-275
Dec 11, 2019
Merged

Revert "change attachment type from Map<String,String> to Map<String,Object> (#4311)#5455
chickenlj merged 3 commits intoapache:2.7.5-releasefrom
chickenlj:revert-attachments-275

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

This reverts commit 333cc2f.

The change was introduced from 3.x, it breaks the API compatibility and is not acceptable in 2.7.x version.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5455 into 2.7.5-release will increase coverage by <.01%.
The diff coverage is 63.75%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.5-release    #5455      +/-   ##
===================================================
+ Coverage            61.07%   61.08%   +<.01%     
  Complexity             423      423              
===================================================
  Files                  919      919              
  Lines                37539    37520      -19     
  Branches              5464     5461       -3     
===================================================
- Hits                 22928    22919       -9     
+ Misses               12105    12095      -10     
  Partials              2506     2506
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/apache/dubbo/rpc/Invocation.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java 56.17% <ø> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/common/serialize/ObjectOutput.java 66.66% <ø> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/common/serialize/ObjectInput.java 33.33% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java 16.66% <ø> (ø) 0 <0> (ø) ⬇️
...le/src/main/java/com/alibaba/dubbo/rpc/Result.java 13.79% <0%> (ø) 0 <0> (ø) ⬇️
...tocol/grpc/interceptors/RpcContextInterceptor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 64.7% <100%> (ø) 0 <0> (ø) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2a564...5ddbe06. Read the comment docs.

@chickenlj chickenlj merged commit bc14a10 into apache:2.7.5-release Dec 11, 2019
@chickenlj chickenlj deleted the revert-attachments-275 branch March 11, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants