Skip to content

[Dubbo-5446] fix aop issue with @Reference#5454

Merged
mercyblitz merged 1 commit intoapache:masterfrom
GungnirLaevatain:fix#5446
Feb 6, 2020
Merged

[Dubbo-5446] fix aop issue with @Reference#5454
mercyblitz merged 1 commit intoapache:masterfrom
GungnirLaevatain:fix#5446

Conversation

@GungnirLaevatain
Copy link
Copy Markdown
Contributor

@GungnirLaevatain GungnirLaevatain commented Dec 11, 2019

What is the purpose of the change

Fix issue#5446
I think using bean from spring instead of ref object for injection can better supports AOP or other extended operations

Brief changelog

org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor

Verifying this change

pass ReferenceAnnotationBeanPostProcessorTest

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 11, 2019 •
edited
Loading

Codecov Report

Merging #5454 into master will decrease coverage by 0.18%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5454      +/-   ##
============================================
- Coverage     61.23%   61.04%   -0.19%     
+ Complexity      424      422       -2     
============================================
  Files           919      919              
  Lines         37520    37536      +16     
  Branches       5462     5463       +1     
============================================
- Hits          22975    22914      -61     
- Misses        12036    12114      +78     
+ Partials       2509     2508       -1
Impacted Files Coverage Δ Complexity Δ
...notation/ReferenceAnnotationBeanPostProcessor.java 80.8% <90%> (+1.39%) 0 <0> (ø) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 46.15% <0%> (-23.08%) 0% <0%> (ø)
...ubbo/registry/support/AbstractRegistryFactory.java 70.58% <0%> (-14.71%) 0% <0%> (ø)
...org/apache/dubbo/registry/dubbo/DubboRegistry.java 56.86% <0%> (-11.77%) 10% <0%> (-1%)
...o/rpc/cluster/support/wrapper/AbstractCluster.java 62.16% <0%> (-10.82%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 70.83% <0%> (-8.34%) 0% <0%> (ø)
...interceptor/ConsumerContextClusterInterceptor.java 84.61% <0%> (-7.7%) 0% <0%> (ø)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 55.55% <0%> (-5.56%) 0% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 63.8% <0%> (-4.11%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eae301...f97d89f. Read the comment docs.

@chickenlj chickenlj requested a review from mercyblitz December 11, 2019 12:26
@chickenlj chickenlj added this to the 2.7.6 milestone Dec 11, 2019
@GungnirLaevatain
Copy link
Copy Markdown
Contributor Author

GungnirLaevatain commented Dec 16, 2019

@mercyblitz PTAL,thanks

@htynkn htynkn changed the title Fix issue#5446 [Dubbo-5446] fix aop issue with @Reference Dec 20, 2019
@htynkn htynkn added the type/need-triage Need maintainers to triage label Dec 20, 2019
@qinliujie qinliujie assigned qinliujie and mercyblitz and unassigned qinliujie Jan 8, 2020
@mercyblitz mercyblitz mentioned this pull request Feb 6, 2020
Merged
@mercyblitz
Copy link
Copy Markdown
Contributor

mercyblitz commented Feb 6, 2020

I merge your PR, first, and My PR will base on it.

@mercyblitz mercyblitz closed this Feb 6, 2020
@mercyblitz mercyblitz reopened this Feb 6, 2020
@mercyblitz mercyblitz merged commit 027c5a6 into apache:master Feb 6, 2020
@justfunxin justfunxin mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mercyblitz mercyblitz Awaiting requested review from mercyblitz

Assignees

@mercyblitz mercyblitz

Labels

type/need-triage Need maintainers to triage

Projects

None yet

Milestone

2.7.6

Development

Successfully merging this pull request may close these issues.

With @Reference, Aop does not work

6 participants

@GungnirLaevatain @codecov-io @mercyblitz @htynkn @qinliujie @chickenlj