optimize : constant names should be all uppercase, separated by underscores#5356
Merged
chickenlj merged 6 commits intoapache:masterfrom Feb 1, 2020
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:optimize_2
Merged
optimize : constant names should be all uppercase, separated by underscores#5356chickenlj merged 6 commits intoapache:masterfrom ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:optimize_2
chickenlj merged 6 commits intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:optimize_2
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5356 +/- ##
============================================
+ Coverage 61.26% 61.42% +0.16%
- Complexity 423 491 +68
============================================
Files 923 926 +3
Lines 37572 37845 +273
Branches 5442 5461 +19
============================================
+ Hits 23018 23247 +229
- Misses 12067 12074 +7
- Partials 2487 2524 +37
Continue to review full report at Codecov.
|
Contributor
|
All changes are limited to static property renames, have no side effect on functionality. |
Author
Of course, I think he can make the code more formal. |
� Conflicts: � dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
� Conflicts: � dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5356 +/- ##
=========================================
Coverage 61.42% 61.42%
- Complexity 490 491 +1
=========================================
Files 926 926
Lines 37845 37845
Branches 5461 5461
=========================================
+ Hits 23246 23247 +1
+ Misses 12076 12074 -2
- Partials 2523 2524 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
optimize : constant names should be all uppercase, separated by underscores
fixes #5355
Brief changelog
1.dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/script/ScriptRouter.java
2.dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/file/FileSystemDynamicConfiguration.java
3.dubbo-common/src/main/java/org/apache/dubbo/common/json/GenericJSONConverter.java
4.dubbo-common/src/main/java/org/apache/dubbo/common/utils/ReflectUtils.java
5.dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ApplicationModel.java
6.dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
7.dubbo-container/dubbo-container-api/src/main/java/org/apache/dubbo/container/Main.java
8.dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/support/AbstractMetadataReport.java
9.dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/BaseWritableMetadataService.java
10.dubbo-metadata/dubbo-metadata-definition-protobuf/src/main/java/org/apache/dubbo/metadata/definition/protobuf/ProtobufTypeBuilder.java
11.dubbo-monitor/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/AbstractMonitorFactory.java
12.dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/DubboLogo.java
13.dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java
14.dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/QosProcessHandler.java
15.dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/handler/TelnetProcessHandler.java
16.dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/server/handler/TelnetProcessHandlerTest.java
17.dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/servlet/DispatcherServlet.java
18.dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
19.dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/DeprecatedFilter.java
20.dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
21.dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/filter/TraceFilter.java
22.dubbo-rpc/dubbo-rpc-native-thrift/src/main/java/org/apache/dubbo/rpc/protocol/nativethrift/ThriftProtocol.java
23.dubbo-serialization/dubbo-serialization-fst/src/main/java/org/apache/dubbo/common/serialize/fst/FstFactory.java
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.