Skip to content

ignore compiler for rat plugin#5295

Merged
chickenlj merged 1 commit intoapache:masterfrom
htynkn:chore/fix-ci
Nov 18, 2019
Merged

ignore compiler for rat plugin#5295
chickenlj merged 1 commit intoapache:masterfrom
htynkn:chore/fix-ci

Conversation

@htynkn
Copy link
Copy Markdown
Member

@htynkn htynkn commented Nov 8, 2019

What is the purpose of the change

Fix ci

Brief changelog

compiler is gradle project which we need more discuss for this one.
Currently it block CI, ignore it first

Verifying this change

CI pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Copy Markdown
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the ignored files from the remote/master branch before merged

@htynkn
Copy link
Copy Markdown
Member Author

htynkn commented Nov 8, 2019

Master branch has compile issue .... via 39f84fe

file:

@htynkn
Copy link
Copy Markdown
Member Author

htynkn commented Nov 8, 2019

test fail:
[ERROR] Failures:
[ERROR] DynamicConfigurationFactoryTest.testDefaultExtension:36 expected: <org.apache.dubbo.common.config.configcenter.file.FileSystemDynamicConfigurationFactory> but was: <org.apache.dubbo.common.config.configcenter.nop.NopDynamicConfigurationFactory>
[ERROR] FileSystemDynamicConfigurationFactoryTest.testGetFactory:36 expected: org.apache.dubbo.common.config.configcenter.nop.NopDynamicConfigurationFactory@556ed69c but was: org.apache.dubbo.common.config.configcenter.file.FileSystemDynamicConfigurationFactory@5657f300
[ERROR] DubboAppenderTest.testClear:79
Expected: a collection with size <1>
but: collection size was <2>

@chickenlj chickenlj merged commit 84574af into apache:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants