Skip to content

Clean up CommandHelper class and add its private ctor#5265

Merged
chickenlj merged 1 commit intoapache:masterfrom
jamesxuhaozhe:master
Nov 18, 2019
Merged

Clean up CommandHelper class and add its private ctor#5265
chickenlj merged 1 commit intoapache:masterfrom
jamesxuhaozhe:master

Conversation

@jamesxuhaozhe
Copy link
Copy Markdown
Contributor

@jamesxuhaozhe jamesxuhaozhe commented Oct 30, 2019

What is the purpose of the change

CommandHelper class isn't formatted correctly, and looks like this util class need its ctor privatized

Brief changelog

1.Reformat the CommandHelper class
2.Add private constructor to this class

Verifying this change

should not bring any side effect

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@jamesxuhaozhe
Copy link
Copy Markdown
Contributor Author

not sure why CI failed, doesn't look like it was because of my change though

@chickenlj chickenlj merged commit 3f1307d into apache:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants