Skip to content

[Dubbo-5215] get & set & remove in org.apache.dubbo.common.utils.Stack take no consideration that index plus mSize is negative#5231

Merged
chickenlj merged 2 commits intoapache:masterfrom
lkj41110:fix_#5215
Nov 18, 2019
Merged

[Dubbo-5215] get & set & remove in org.apache.dubbo.common.utils.Stack take no consideration that index plus mSize is negative#5231
chickenlj merged 2 commits intoapache:masterfrom
lkj41110:fix_#5215

Conversation

@lkj41110
Copy link
Copy Markdown
Contributor

@lkj41110 lkj41110 commented Oct 24, 2019 •
edited
Loading

What is the purpose of the change

fix #5215

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 24, 2019

Codecov Report

Merging #5231 into master will increase coverage by 0.54%.
The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5231      +/-   ##
============================================
+ Coverage     63.57%   64.11%   +0.54%     
+ Complexity      463      462       -1     
============================================
  Files           791      770      -21     
  Lines         35225    33399    -1826     
  Branches       5503     5262     -241     
============================================
- Hits          22394    21414     -980     
+ Misses        10302     9559     -743     
+ Partials       2529     2426     -103
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/dubbo/common/utils/Stack.java 96.77% <96.77%> (ø) 0 <0> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
...mmon/threadpool/support/AbortPolicyWithReport.java 83.78% <0%> (-5.41%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...exchange/support/header/HeaderExchangeHandler.java 64.75% <0%> (-2.46%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.77% <0%> (-2.28%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-1.89%) 0% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20351b0...474c7c8. Read the comment docs.

@chickenlj chickenlj merged commit 6898691 into apache:master Nov 18, 2019
@lkj41110 lkj41110 deleted the fix_#5215 branch November 18, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

functions get & set & remove in org.apache.dubbo.common.utils.Stack take no consideration that index plus mSize is negative

3 participants

@lkj41110 @codecov-io @chickenlj