[Dubbo-4991] Fix zk client create logic#5139
Merged
chickenlj merged 3 commits intoapache:masterfrom Feb 7, 2020
htynkn:bugfix/handle-zk-by-full-path
Merged
[Dubbo-4991] Fix zk client create logic#5139chickenlj merged 3 commits intoapache:masterfrom htynkn:bugfix/handle-zk-by-full-path
chickenlj merged 3 commits intoapache:masterfrom
htynkn:bugfix/handle-zk-by-full-path
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5139 +/- ##
==========================================
- Coverage 61.3% 61.2% -0.1%
+ Complexity 427 423 -4
==========================================
Files 919 919
Lines 37487 37502 +15
Branches 5461 5465 +4
==========================================
- Hits 22980 22954 -26
- Misses 12003 12037 +34
- Partials 2504 2511 +7
Continue to review full report at Codecov.
|
Closed
Contributor
|
LGTM. |
chickenlj
approved these changes
Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix #4991
Brief changelog
Use username+password+address as zk client cache map key
Verifying this change
CI pass
More detail refer to issue detail
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.