concurrent cache bug fix#5043
Merged
chickenlj merged 1 commit intoapache:masterfrom Nov 18, 2019
fakefrog:master
Merged
Conversation
|
baiyundou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
chickenlj
approved these changes
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The codes are not thread-safe,
"
ret = makeWrapper(c);
WRAPPER_MAP.put(c, ret);
"
should be replaced by
"
WRAPPER_MAP.putIfAbsent(c, makeWrapper(c));
ret = WRAPPER_MAP.get(c);
"
as the key may be put into the map twice.
Futuhermore,the codes can also be replaced by lambda expression