fix default setting#4955
Conversation
brucelwl
commented
Aug 27, 2019
ExecutionChannelHandler
…gger "InternalLogger" in netty.
* use three different kinds of cache factory to increase test coverages * add unit test cases for dubbo-filter module * add copyright and made small refactor * make sure Jcache will exceed expired period
…faceConfig should be in setter instead of getter (#1732)
* finish unit test for AbstractMethodConfig * finish unit test for AbstractReferenceConfig * move to right package * finish unit test for AbstractReferenceConfig * finish unit test for AbstractMethodConfig * finish unit test for AbstractReferenceConfig * move to right package * finish unit test for AbstractReferenceConfig * unit test for AbstractServiceConfig, also fix logic issue in setListener/getListener
* unit test for ApplicationConfig * fix typo * unit test for ArgumentConfig * unit test for ConsumerConfig * unit test for MethodConfig * unit test for ModuleConfig * unit test for MonitorConfig * unit test for ProtocolConfig * unit test for ApplicationConfig * fix typo * unit test for ArgumentConfig * unit test for ConsumerConfig * unit test for MethodConfig * unit test for ModuleConfig * unit test for MonitorConfig * unit test for ProtocolConfig * unit test for ProviderConfig * make test stable
(cherry picked from commit 430fb4c)
|
Could you provide more detail how this change? |
|
Codecov Report
@@ Coverage Diff @@
## 2.6.x #4955 +/- ##
============================================
- Coverage 47.38% 47.35% -0.03%
+ Complexity 4392 4391 -1
============================================
Files 562 562
Lines 25053 25052 -1
Branches 4426 4426
============================================
- Hits 11871 11864 -7
- Misses 11357 11361 +4
- Partials 1825 1827 +2
Continue to review full report at Codecov.
|
1.能描述一下相关场景吗?getInjectedMethodObjectsMap和getInjectedFieldObjectsMap可以满足需求吗?我们需要比较充足的理由再调整一个方法的访问级别,同时getInjectedObjects方法的返回参数可能是不兼容的变更,不是很建议这么操作 2.DubboConfigBindingBeanPostProcessor中的这两个值提供了对应的setter方法,如果是spring配置,也是可以配置property变更的,能描述你使用中的具体问题吗? |
|
@htynkn 2 建议仔细看一下代码,DubboConfigBindingBeanPostProcessor 中的get/set根据就在内部使用,哪么什么属性可以变更 |
|
@mercyblitz 帮忙看下这个PR吧。 |
|
|
beiwei30
left a comment
There was a problem hiding this comment.
LGTM, but I will ask Mercy Ma to double check.