Skip to content

[dubbo-4097] fix registry of etcd set 'group' cannot isolate#4825

Merged
AlbumenJ merged 2 commits intoapache:masterfrom
kaori-seasons:dubbo-etcd3
Apr 11, 2021
Merged

[dubbo-4097] fix registry of etcd set 'group' cannot isolate#4825
AlbumenJ merged 2 commits intoapache:masterfrom
kaori-seasons:dubbo-etcd3

Conversation

@kaori-seasons
Copy link
Copy Markdown

@kaori-seasons kaori-seasons commented Aug 14, 2019 •
edited
Loading

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

fix registry of etcd set 'group' cannot isolate #4097

@tswstarplanet
Copy link
Copy Markdown
Contributor

tswstarplanet commented Aug 14, 2019

you can add "fix #xxx" in the "What is the purpose of the change" section, this may link the pr to the corresponding issue

@kaori-seasons
Copy link
Copy Markdown
Author

kaori-seasons commented Aug 14, 2019 •
edited
Loading

you can add "fix #xxx" in the "What is the purpose of the change" section, this may link the pr to the corresponding issue

Hello, I have added #4097

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #4825 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4825      +/-   ##
============================================
- Coverage     61.17%   61.15%   -0.02%     
+ Complexity      424      423       -1     
============================================
  Files           919      919              
  Lines         37487    37491       +4     
  Branches       5461     5462       +1     
============================================
- Hits          22933    22928       -5     
- Misses        12049    12050       +1     
- Partials       2505     2513       +8
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 70.83% <0%> (-8.34%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 68.21% <0%> (-3.11%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-2.81%) 16% <0%> (-1%)
...dubbo/remoting/exchange/support/DefaultFuture.java 67.27% <0%> (-1.82%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.75% <0%> (-0.35%) 0% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9746a0...285af33. Read the comment docs.

@apache apache deleted a comment from CLAassistant Nov 29, 2019
@AlbumenJ AlbumenJ added this to the 2.7.11 milestone Apr 11, 2021
@AlbumenJ AlbumenJ merged commit 6504db6 into apache:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.11

Development

Successfully merging this pull request may close these issues.

5 participants

@kaori-seasons @tswstarplanet @codecov-io @AlbumenJ @lovepoem