Skip to content

[Enhancement] JsonRpcProtocol support Generalization #4595#4596

Merged
hengyunabc merged 7 commits intoapache:masterfrom
CrazyHZM:jsonRpcGeneric
Feb 5, 2020
Merged

[Enhancement] JsonRpcProtocol support Generalization #4595#4596
hengyunabc merged 7 commits intoapache:masterfrom
CrazyHZM:jsonRpcGeneric

Conversation

@CrazyHZM
Copy link
Copy Markdown
Member

@CrazyHZM CrazyHZM commented Jul 18, 2019

What is the purpose of the change

JsonRpcProtocol support Generalization #4595

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 18, 2019 •
edited
Loading

Codecov Report

Merging #4596 into master will decrease coverage by 0.01%.
The diff coverage is 46.8%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4596      +/-   ##
============================================
- Coverage     63.96%   63.94%   -0.02%     
- Complexity      452      457       +5     
============================================
  Files           769      771       +2     
  Lines         33206    33248      +42     
  Branches       5237     5241       +4     
============================================
+ Hits          21239    21261      +22     
- Misses         9546     9561      +15     
- Partials       2421     2426       +5
Impacted Files Coverage Δ Complexity Δ
.../dubbo/rpc/protocol/http/JsonRemoteInvocation.java 0% <0%> (ø) 0 <0> (?)
...bbo/rpc/protocol/http/JsonRpcProxyFactoryBean.java 46.66% <46.66%> (ø) 3 <3> (?)
...g/apache/dubbo/rpc/protocol/http/HttpProtocol.java 51.25% <68.18%> (+5.21%) 8 <4> (+2) ⬆️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0%> (-4.55%) 20% <0%> (-1%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.77% <0%> (-2.28%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.36%) 0% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d564e7...c421f6f. Read the comment docs.

@CrazyHZM CrazyHZM mentioned this pull request Aug 2, 2019
Merged
6 tasks
@CrazyHZM
Merge branch 'master' into jsonRpcGeneric
795e73e 
# Conflicts:
#	dubbo-rpc/dubbo-rpc-jsonrpc/src/main/java/org/apache/dubbo/rpc/protocol/jsonrpc/JsonRpcProtocol.java
#	dubbo-rpc/dubbo-rpc-jsonrpc/src/test/java/org/apache/dubbo/rpc/protocol/jsonrpc/JsonRpcProtocolTest.java
@CrazyHZM
Handling conflicts
2a43b51
@CrazyHZM
delete useless file
e3cf09b
@CrazyHZM
modify
5c5788d
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 6, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CrazyHZM
Merge branch 'master' into jsonRpcGeneric
1cba5fd 
# Conflicts:
#	dubbo-rpc/dubbo-rpc-http/src/test/java/org/apache/dubbo/rpc/protocol/http/HttpProtocolTest.java
@CrazyHZM
handling conflicts
c421f6f
@CrazyHZM CrazyHZM added this to the 2.7.5 milestone Sep 12, 2019
@chickenlj chickenlj modified the milestones: 2.7.5, 2.7.6 Dec 30, 2019
@hengyunabc
Copy link
Copy Markdown
Contributor

hengyunabc commented Feb 4, 2020

@CrazyHZM 这个 dubbo.attachments 是什么用途的？没看到有取出使用的地方。是从 RmiRemoteInvocation 里来的？

@hengyunabc hengyunabc merged commit 72eaf04 into apache:master Feb 5, 2020
@CrazyHZM CrazyHZM deleted the jsonRpcGeneric branch April 27, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hengyunabc hengyunabc

Labels

None yet

Projects

None yet

Milestone

2.7.6

Development

Successfully merging this pull request may close these issues.

5 participants

@CrazyHZM @codecov-io @CLAassistant @hengyunabc @chickenlj