Skip to content

Fixing typos#3030

Merged
carryxyh merged 1 commit intoapache:masterfrom
sergioescala:fixing-typos
Dec 21, 2018
Merged

Fixing typos#3030
carryxyh merged 1 commit intoapache:masterfrom
sergioescala:fixing-typos

Conversation

@sergioescala
Copy link
Copy Markdown
Contributor

@sergioescala sergioescala commented Dec 20, 2018

What is the purpose of the change

Fixing typos

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3030 into master will increase coverage by <.01%.
The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
+ Coverage   64.24%   64.25%   +<.01%     
==========================================
  Files         584      584              
  Lines       26056    26056              
  Branches     4562     4562              
==========================================
+ Hits        16740    16742       +2     
+ Misses       7133     7131       -2     
  Partials     2183     2183
Impacted Files Coverage Δ
...annotation/ServiceAnnotationBeanPostProcessor.java 86.89% <ø> (ø) ⬆️
...ing/transport/netty4/NettyBackedChannelBuffer.java 19.04% <ø> (ø) ⬆️
...ava/org/apache/dubbo/common/utils/ConfigUtils.java 77.93% <ø> (ø) ⬆️
...apache/dubbo/rpc/filter/tps/DefaultTPSLimiter.java 66.66% <ø> (ø) ⬆️
...notation/ReferenceAnnotationBeanPostProcessor.java 76.38% <ø> (ø) ⬆️
...ting/transport/netty/NettyBackedChannelBuffer.java 0% <ø> (ø) ⬆️
...he/dubbo/common/io/UnsafeByteArrayInputStream.java 82.92% <ø> (ø) ⬆️
.../CompatibleServiceAnnotationBeanPostProcessor.java 0% <ø> (ø) ⬆️
...pc/cluster/support/wrapper/MockClusterInvoker.java 71.42% <ø> (ø) ⬆️
...a/org/apache/dubbo/remoting/exchange/Response.java 94.73% <ø> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae5fa8...334df82. Read the comment docs.

Copy link
Copy Markdown
Contributor

@lixiaojiee lixiaojiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're really careful.

@carryxyh
Copy link
Copy Markdown
Member

Thank u very much!
I have seen all of them. LGTM.

@carryxyh carryxyh merged commit 3e6ae66 into apache:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants