Skip to content

applicationmodel provider & consumer serviceName is not unique#2582

Closed
haiyang1985 wants to merge 1 commit intoapache:2.6.4-releasefrom
haiyang1985:2.6.4-applicationmodel-cache
Closed

applicationmodel provider & consumer serviceName is not unique#2582
haiyang1985 wants to merge 1 commit intoapache:2.6.4-releasefrom
haiyang1985:2.6.4-applicationmodel-cache

Conversation

@haiyang1985
Copy link
Copy Markdown
Member

What is the purpose of the change

For below two situations, the provider & consumer cache in ApplicationModel is not unique.

  1. create two ReferenceConfig for same service with different configuration.
    <dubbo:reference id="demoService" interface="com.alibaba.dubbo.DemoService">
    </dubbo:reference>
    <dubbo:reference id="demoServiceAsync" interface="com.alibaba.dubbo.DemoService" async="true">
    </dubbo:reference>
  2. create two ServiceConfig for same service with different implementation.

Brief changelog

Currently, dubbo uses interface+group+version for the cache unique serviceName. To support above two scenario, we are going to add hashCode for the unique serviceName.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Copy Markdown
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with the logic change against getUniqueServiceName. Instead, I think we should change org.apache.dubbo.config.model.ApplicationModel's implementation to allow multiple consumer/service models registered under the same service.

@diecui1202 diecui1202 closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants