applicationmodel provider & consumer serviceName is not unique#2582
Closed
haiyang1985 wants to merge 1 commit intoapache:2.6.4-releasefrom
haiyang1985:2.6.4-applicationmodel-cache
Closed
applicationmodel provider & consumer serviceName is not unique#2582haiyang1985 wants to merge 1 commit intoapache:2.6.4-releasefrom haiyang1985:2.6.4-applicationmodel-cache
haiyang1985 wants to merge 1 commit intoapache:2.6.4-releasefrom
haiyang1985:2.6.4-applicationmodel-cache
Conversation
2 tasks
beiwei30
requested changes
Oct 8, 2018
Member
beiwei30
left a comment
There was a problem hiding this comment.
I don't agree with the logic change against getUniqueServiceName. Instead, I think we should change org.apache.dubbo.config.model.ApplicationModel's implementation to allow multiple consumer/service models registered under the same service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For below two situations, the provider & consumer cache in ApplicationModel is not unique.
<dubbo:reference id="demoService" interface="com.alibaba.dubbo.DemoService">
</dubbo:reference>
<dubbo:reference id="demoServiceAsync" interface="com.alibaba.dubbo.DemoService" async="true">
</dubbo:reference>
Brief changelog
Currently, dubbo uses interface+group+version for the cache unique serviceName. To support above two scenario, we are going to add hashCode for the unique serviceName.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.