Skip to content

supplemental change for pull request 1973#2329

Merged
beiwei30 merged 2 commits intoapache:masterfrom
beiwei30:pr1973-follow-up
Aug 22, 2018
Merged

supplemental change for pull request 1973#2329
beiwei30 merged 2 commits intoapache:masterfrom
beiwei30:pr1973-follow-up

Conversation

@beiwei30
Copy link
Copy Markdown
Member

What is the purpose of the change

supplemental change for PR#1973

Brief changelog

  • add necessary content in LICENSE
  • move utility method from StringUtils to ClassHelper

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 merged commit 7500033 into apache:master Aug 22, 2018
@beiwei30 beiwei30 deleted the pr1973-follow-up branch August 22, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant