[dubbo-1689]: Enhance the test coverage part-10 : dubbo-plugin module#1982
Merged
beiwei30 merged 4 commits intoapache:masterfrom Jun 25, 2018
beiwei30:qos-unit-test
Merged
[dubbo-1689]: Enhance the test coverage part-10 : dubbo-plugin module#1982beiwei30 merged 4 commits intoapache:masterfrom beiwei30:qos-unit-test
beiwei30 merged 4 commits intoapache:masterfrom
beiwei30:qos-unit-test
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
==========================================
+ Coverage 50.6% 50.8% +0.2%
- Complexity 4745 4763 +18
==========================================
Files 562 562
Lines 25213 25218 +5
Branches 4449 4449
==========================================
+ Hits 12758 12811 +53
+ Misses 10524 10470 -54
- Partials 1931 1937 +6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
issue#1689: Enhance the test coverage part-10 : dubbo-plugin module
Brief changelog
dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/protocol/QosProtocolWrapper.java
dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/protocol/QosProtocolWrapperTest.java
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.