Skip to content

[dubbo-1689]: Enhance the test coverage part-10 : dubbo-plugin module#1980

Merged
beiwei30 merged 4 commits intoapache:masterfrom
beiwei30:qos-unit-test
Jun 25, 2018
Merged

[dubbo-1689]: Enhance the test coverage part-10 : dubbo-plugin module#1980
beiwei30 merged 4 commits intoapache:masterfrom
beiwei30:qos-unit-test

Conversation

@beiwei30
Copy link
Copy Markdown
Member

@beiwei30 beiwei30 commented Jun 25, 2018

What is the purpose of the change

issue#1689: Enhance the test coverage part-10 : dubbo-plugin module

Brief changelog

dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OfflineTest.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/OnlineTest.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/QuitTest.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/TestRegistryFactory.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/util/CommandHelperTest.java
dubbo-plugin/dubbo-qos/src/test/resources/META-INF/services/org.apache.dubbo.registry.RegistryFactory

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 25, 2018 •
edited
Loading

Codecov Report

Merging #1980 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1980     +/-   ##
===========================================
+ Coverage     50.56%   50.67%   +0.1%     
- Complexity     4742     4751      +9     
===========================================
  Files           562      562             
  Lines         25213    25213             
  Branches       4449     4449             
===========================================
+ Hits          12749    12776     +27     
+ Misses        10546    10511     -35     
- Partials       1918     1926      +8
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 40% <0%> (-36%) 6% <0%> (-1%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) 3% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 15% <0%> (ø)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 54.43% <0%> (-1.27%) 12% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyClient.java 83.05% <0%> (+10.16%) 13% <0%> (+1%) ⬆️
...g/apache/dubbo/qos/command/util/CommandHelper.java 88.23% <0%> (+23.52%) 5% <0%> (+1%) ⬆️
...n/java/org/apache/dubbo/qos/command/impl/Quit.java 100% <0%> (+50%) 2% <0%> (+1%) ⬆️
...java/org/apache/dubbo/qos/command/impl/Online.java 83.33% <0%> (+70.83%) 5% <0%> (+4%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 590bbb2...ffe1df4. Read the comment docs.

@beiwei30 beiwei30 merged commit f186f2b into apache:master Jun 25, 2018
@beiwei30 beiwei30 deleted the qos-unit-test branch June 25, 2018 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beiwei30 @codecov-io