Skip to content

fix #1925 #1969

Merged
ralf0131 merged 1 commit intoapache:masterfrom
hqq2023623:fix#1925
Jun 21, 2018
Merged

fix #1925 #1969
ralf0131 merged 1 commit intoapache:masterfrom
hqq2023623:fix#1925

Conversation

@hqq2023623
Copy link
Copy Markdown
Contributor

@hqq2023623 hqq2023623 commented Jun 21, 2018

What is the purpose of the change

fix #1925

Brief changelog

remove redundant comparison

Verifying this change

remove redundant comparison

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 21, 2018

Codecov Report

Merging #1969 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1969      +/-   ##
============================================
- Coverage     50.04%   50.02%   -0.02%     
- Complexity     4706     4708       +2     
============================================
  Files           562      562              
  Lines         25213    25213              
  Branches       4449     4449              
============================================
- Hits          12618    12613       -5     
- Misses        10690    10694       +4     
- Partials       1905     1906       +1
Impacted Files Coverage Δ Complexity Δ
...va/org/apache/dubbo/config/spring/ServiceBean.java 52.94% <0%> (ø) 41 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 47.44% <0%> (ø) 62 <0> (ø) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) 3% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (ø)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 60% <0%> (-1.25%) 21% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+3.79%) 13% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21d994...895278c. Read the comment docs.

@ralf0131
Copy link
Copy Markdown
Contributor

ralf0131 commented Jun 21, 2018

Looks good to me! Thanks for the pull request.

@ralf0131 ralf0131 merged commit 705bf37 into apache:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redundant toString() is called

3 participants

@hqq2023623 @codecov-io @ralf0131