Skip to content

fix old groupId#1959

Merged
lovepoem merged 1 commit intoapache:masterfrom
diecui1202:fix-old-groupId
Jun 19, 2018
Merged

fix old groupId#1959
lovepoem merged 1 commit intoapache:masterfrom
diecui1202:fix-old-groupId

Conversation

@diecui1202
Copy link
Copy Markdown

What is the purpose of the change

fix old groupId

Brief changelog

dubbo-remoting/dubbo-remoting-p2p/pom.xml

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c0ca042). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1959   +/-   ##
=========================================
  Coverage          ?   49.88%           
  Complexity        ?     4687           
=========================================
  Files             ?      562           
  Lines             ?    25214           
  Branches          ?     4449           
=========================================
  Hits              ?    12579           
  Misses            ?    10726           
  Partials          ?     1909

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ca042...e662a11. Read the comment docs.

@lovepoem
Copy link
Copy Markdown
Member

Look good to me

@lovepoem lovepoem merged commit 5c62d1c into apache:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants