Skip to content

[Dubbo-1694] add test for p2p and zookeeper#1958

Merged
beiwei30 merged 1 commit intoapache:masterfrom
diamondblack:chore/add-unit-test-for-zookeeper-and-p2p
Jun 19, 2018
Merged

[Dubbo-1694] add test for p2p and zookeeper#1958
beiwei30 merged 1 commit intoapache:masterfrom
diamondblack:chore/add-unit-test-for-zookeeper-and-p2p

Conversation

@htynkn
Copy link
Copy Markdown
Member

@htynkn htynkn commented Jun 19, 2018

What is the purpose of the change

add unit test for p2p remoting module
add unit test for zookeeper remoting module

Brief changelog

this is part one for #1694 , still working on p2p remoting module to add more test.

Verifying this change

CI Pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 19, 2018 •
edited
Loading

Codecov Report

Merging #1958 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1958      +/-   ##
============================================
+ Coverage     50.47%   50.91%   +0.43%     
- Complexity     4746     4849     +103     
============================================
  Files           518      532      +14     
  Lines         25424    25833     +409     
  Branches       4560     4615      +55     
============================================
+ Hits          12834    13152     +318     
- Misses        10641    10695      +54     
- Partials       1949     1986      +37
Impacted Files Coverage Δ Complexity Δ
.../dubbo/remoting/transport/netty4/NettyChannel.java 60% <0%> (-6.25%) 21% <0%> (-2%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 15% <0%> (ø)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...ng/p2p/exchange/support/FileExchangeNetworker.java 0% <0%> (ø) 0% <0%> (?)
...g/p2p/exchange/support/MulticastExchangeGroup.java 76.59% <0%> (ø) 7% <0%> (?)
...ng/p2p/exchange/support/AbstractExchangeGroup.java 48.88% <0%> (ø) 7% <0%> (?)
...che/dubbo/remoting/p2p/support/MulticastGroup.java 76.59% <0%> (ø) 7% <0%> (?)
...ubbo/remoting/p2p/exchange/ExchangeNetworkers.java 0% <0%> (ø) 0% <0%> (?)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e6fdb...e65d418. Read the comment docs.

@beiwei30 beiwei30 merged commit 9ee83e4 into apache:master Jun 19, 2018
@htynkn htynkn deleted the chore/add-unit-test-for-zookeeper-and-p2p branch June 19, 2018 03:10
@lovepoem lovepoem mentioned this pull request Jun 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@htynkn @codecov-io @beiwei30