Skip to content

[Dubbo-1927]: Enhance IDE support for custom spring namespace elements (dubbo)#1953

Merged
beiwei30 merged 1 commit intoapache:masterfrom
ulinkwo:enhancing-ide-support
Jun 19, 2018
Merged

[Dubbo-1927]: Enhance IDE support for custom spring namespace elements (dubbo)#1953
beiwei30 merged 1 commit intoapache:masterfrom
ulinkwo:enhancing-ide-support

Conversation

@ulinkwo
Copy link
Copy Markdown
Contributor

@ulinkwo ulinkwo commented Jun 15, 2018

What is the purpose of the change

#1944 Enhance IDE support for custom spring namespace elements (dubbo)

Brief changelog

Enhance IDE support for custom spring namespace elements (dubbo)

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 19, 2018

Codecov Report

Merging #1953 into master will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1953     +/-   ##
===========================================
+ Coverage     50.47%   50.88%   +0.4%     
- Complexity     4746     4849    +103     
===========================================
  Files           518      532     +14     
  Lines         25424    25833    +409     
  Branches       4560     4615     +55     
===========================================
+ Hits          12834    13145    +311     
- Misses        10641    10703     +62     
- Partials       1949     1985     +36
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-10.17%) 12% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-4.17%) 3% <0%> (ø)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (-1.25%) 22% <0%> (-1%)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (ø) 7% <0%> (?)
.../apache/dubbo/remoting/p2p/support/ServerPeer.java 21.27% <0%> (ø) 4% <0%> (?)
...g/p2p/exchange/support/MulticastExchangeGroup.java 76.59% <0%> (ø) 7% <0%> (?)
...ubbo/remoting/p2p/exchange/ExchangeNetworkers.java 0% <0%> (ø) 0% <0%> (?)
...che/dubbo/remoting/p2p/support/MulticastGroup.java 76.59% <0%> (ø) 7% <0%> (?)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e6fdb...3943b44. Read the comment docs.

@beiwei30 beiwei30 merged commit 99a01d5 into apache:master Jun 19, 2018
@ulinkwo ulinkwo deleted the enhancing-ide-support branch June 19, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ulinkwo @codecov-io @beiwei30