Skip to content

Add compatible module and rename groupId to org.apache.dubbo#1952

Merged
beiwei30 merged 15 commits intoapache:masterfrom
diecui1202:add-compatible-module
Jun 19, 2018
Merged

Add compatible module and rename groupId to org.apache.dubbo#1952
beiwei30 merged 15 commits intoapache:masterfrom
diecui1202:add-compatible-module

Conversation

@diecui1202
Copy link
Copy Markdown

@diecui1202 diecui1202 commented Jun 15, 2018

What is the purpose of the change

Add compatible module and rename groupId to org.apache.dubbo

Brief changelog

  1. Add single module named "dubbo-compatible", and support limited old extension, such Filter.
  2. rename groupId to org.apache.dubbo

Verifying this change

All unit cases are pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 19, 2018

Codecov Report

Merging #1952 into master will decrease coverage by 1.07%.
The diff coverage is 6.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1952      +/-   ##
===========================================
- Coverage     50.47%   49.4%   -1.08%     
+ Complexity     4746    4585     -161     
===========================================
  Files           518     548      +30     
  Lines         25424   24805     -619     
  Branches       4560    4394     -166     
===========================================
- Hits          12834   12256     -578     
- Misses        10641   10676      +35     
+ Partials       1949    1873      -76
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/alibaba/dubbo/common/Constants.java 0% <0%> (ø) 0 <0> (?)
...ompatibleReferenceAnnotationBeanPostProcessor.java 0% <0%> (ø) 0 <0> (?)
.../alibaba/dubbo/common/serialize/Serialization.java 0% <0%> (ø) 0 <0> (?)
.../java/com/alibaba/dubbo/config/ProviderConfig.java 0% <0%> (ø) 0 <0> (?)
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...g/apache/dubbo/rpc/proxy/AbstractProxyFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/dubbo/rpc/protocol/rest/support/ContentType.java 0% <0%> (ø) 0 <0> (?)
.../src/main/java/com/alibaba/dubbo/rpc/Exporter.java 0% <0%> (ø) 0 <0> (?)
...o/rpc/cluster/loadbalance/AbstractLoadBalance.java 0% <0%> (ø) 0 <0> (?)
...ory/annotation/CompatibleReferenceBeanBuilder.java 0% <0%> (ø) 0 <0> (?)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e6fdb...5075229. Read the comment docs.

@beiwei30 beiwei30 merged commit c0ca042 into apache:master Jun 19, 2018
@kayyellow
Copy link
Copy Markdown

kayyellow commented May 21, 2019

hi,
com.alibaba.dubbo.registry.RegistryFactory import the org.apache.dubbo.registry.Registry, but I extended the com.alibaba.dubbo.registry.Registry in version 2.5.4. So it cannot be compatible. Do u miss to import com.alibaba.dubbo.registry.Registry rather than org.apache.dubbo.registry.Registry ?

package com.alibaba.dubbo.registry;

import com.alibaba.dubbo.common.URL;
import org.apache.dubbo.registry.Registry;

/** @deprecated */
@deprecated
public interface RegistryFactory extends org.apache.dubbo.registry.RegistryFactory {
Registry getRegistry(URL var1);

default Registry getRegistry(org.apache.dubbo.common.URL url) {
    return this.getRegistry(new URL(url));
}

}

@kayyellow
Copy link
Copy Markdown

kayyellow commented May 21, 2019

@beiwei30 @diecui1202 Hope to see the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diecui1202 @codecov-io @kayyellow @beiwei30