Skip to content

Fix a bug when the provider write a throwable into aysnc context#1946

Merged
beiwei30 merged 1 commit intoapache:masterfrom
carryxyh:fixasync
Jun 19, 2018
Merged

Fix a bug when the provider write a throwable into aysnc context#1946
beiwei30 merged 1 commit intoapache:masterfrom
carryxyh:fixasync

Conversation

@carryxyh
Copy link
Copy Markdown
Member

@carryxyh carryxyh commented Jun 15, 2018

  • fix a bug when the provider write a throwable into aysnc context
  • sth doc
  • simple code

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 15, 2018

Codecov Report

Merging #1946 into master will increase coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1946      +/-   ##
============================================
+ Coverage     50.31%   50.44%   +0.13%     
- Complexity     4736     4744       +8     
============================================
  Files           518      518              
  Lines         25421    25423       +2     
  Branches       4546     4560      +14     
============================================
+ Hits          12790    12825      +35     
+ Misses        10670    10647      -23     
+ Partials       1961     1951      -10
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/rpc/AsyncContextImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-1.26%) 12% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 63.33% <0%> (-1.08%) 11% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <0%> (-0.92%) 9% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 47.68% <0%> (+0.71%) 38% <0%> (ø) ⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 3% <0%> (ø) ⬇️
.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java 45.31% <0%> (+1.56%) 8% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 57.74% <0%> (+1.67%) 41% <0%> (+3%) ⬆️
...in/java/org/apache/dubbo/common/utils/IOUtils.java 86.95% <0%> (+2.17%) 16% <0%> (+1%) ⬆️
...va/org/apache/dubbo/remoting/exchange/Request.java 85.71% <0%> (+2.38%) 20% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92a553...70693d7. Read the comment docs.

@beiwei30 beiwei30 merged commit d21d994 into apache:master Jun 19, 2018
@carryxyh carryxyh deleted the fixasync branch June 20, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carryxyh @codecov-io @beiwei30