[Dubbo-SPI] Spring spi support inject by type#1456
Closed
chickenlj wants to merge 2 commits intoapache:masterfrom
chickenlj:spring_spi_injection_by_type
Closed
[Dubbo-SPI] Spring spi support inject by type#1456chickenlj wants to merge 2 commits intoapache:masterfrom chickenlj:spring_spi_injection_by_type
chickenlj wants to merge 2 commits intoapache:masterfrom
chickenlj:spring_spi_injection_by_type
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
- Coverage 31.59% 31.57% -0.03%
==========================================
Files 682 682
Lines 33035 33046 +11
Branches 6592 6596 +4
==========================================
- Hits 10438 10433 -5
- Misses 20748 20757 +9
- Partials 1849 1856 +7
Continue to review full report at Codecov.
|
nzomkxia
reviewed
Apr 9, 2018
|
|
||
| for (ApplicationContext context : contexts) { | ||
| try { | ||
| return context.getBean(type); |
Member
There was a problem hiding this comment.
whether the getBean() returns null or not, this line will end the function progress, is it the real purpose?
Member
There was a problem hiding this comment.
We should consider multiple matching conditions for the same interface type.
6 tasks
Contributor
Author
|
See #1837 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Spring spi support inject by type. Not necessary to support spring 2.5 or lower.
Brief changelog
SpringExtensionFactory
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.