Environment
- Dubbo version: master branch
- Operating System version: Mac os
- Java version: 1.8
Steps to reproduce this issue
org.apache.dubbo.rpc.protocol.dubbo.support.DemoService add method
String getPerson(Yee yee);
org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl
@Override
public String getPerson(Yee yee) {
return yee.getAddress();
}
public class Yee implements Serializable {
private String address;
}
public class Man implements Serializable {
private static final long serialVersionUID = 1L;
private String name;
private int age;
}
org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl add UT
@Test
public void testInvokeMultiJsonParamMethod2() throws RemotingException {
mockChannel = mock(Channel.class);
given(mockChannel.getAttribute("telnet.service")).willReturn(null);
given(mockChannel.getLocalAddress()).willReturn(NetUtils.toAddress("127.0.0.1:5555"));
given(mockChannel.getRemoteAddress()).willReturn(NetUtils.toAddress("127.0.0.1:20886"));
ProviderModel providerModel = new ProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService", new DemoServiceImpl(), DemoService.class);
ApplicationModel.initProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService", providerModel);
String param = "{\"address\":\"Dubbo\"}";
String result = invoke.telnet(mockChannel, "getPerson(" + param + ")");
assertTrue(result.contains("result: \"Dubbo"));
}
- UT fail,Find the wrong overload method
Expected Result
Call getPerson(Yee yee)
Actual Result
Call getPerson(Man man)
Suggestion
If the overload method parameters are different in length, allowed to not pass class parameter, otherwise prompted user must pass the class parameter.
@beiwei30
Environment
Steps to reproduce this issue
org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceadd methodorg.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImplorg.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpladd UTExpected Result
Call
getPerson(Yee yee)Actual Result
Call
getPerson(Man man)Suggestion
If the overload method parameters are different in length, allowed to not pass
classparameter, otherwise prompted user must pass theclassparameter.@beiwei30