solve #6842 Broadcast cluster means that multiple machines will be called,which is not converted to injvm protocol at this time.

xiaoheng1 · xiaoheng1 · commit 64b3771fd73b · 2021-03-13T14:42:03.000+08:00
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java b/dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java
@@ -236,6 +236,11 @@ public interface CommonConstants {
     String PORT_KEY = "port";
     String DUBBO_IP_TO_BIND = "DUBBO_IP_TO_BIND";
 
+    /**
+     * broadcast cluster.
+     */
+    String BROADCAST_CLUSTER = "broadcast";
+
     /**
      * The property name for {@link NetworkInterface#getDisplayName() the name of network interface} that
      * the Dubbo application prefers
diff --git a/dubbo-rpc/dubbo-rpc-injvm/src/main/java/org/apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java b/dubbo-rpc/dubbo-rpc-injvm/src/main/java/org/apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java
@@ -29,6 +29,8 @@
 
 import java.util.Map;
 
+import static org.apache.dubbo.common.constants.CommonConstants.BROADCAST_CLUSTER;
+import static org.apache.dubbo.common.constants.CommonConstants.CLUSTER_KEY;
 import static org.apache.dubbo.rpc.Constants.SCOPE_KEY;
 import static org.apache.dubbo.rpc.Constants.SCOPE_LOCAL;
 import static org.apache.dubbo.rpc.Constants.SCOPE_REMOTE;
@@ -111,6 +113,11 @@ public boolean isInjvmRefer(URL url) {
             // generic invocation is not local reference
             return false;
         } else if (getExporter(exporterMap, url) != null) {
+            // Broadcast cluster means that multiple machines will be called,
+            // which is not converted to injvm protocol at this time.
+            if (BROADCAST_CLUSTER.equalsIgnoreCase(url.getParameter(CLUSTER_KEY))) {
+                return false;
+            }
             // by default, go through local reference if there's the service exposed locally
             return true;
         } else {
diff --git a/dubbo-rpc/dubbo-rpc-injvm/src/test/java/org/apache/dubbo/rpc/protocol/injvm/InjvmProtocolTest.java b/dubbo-rpc/dubbo-rpc-injvm/src/test/java/org/apache/dubbo/rpc/protocol/injvm/InjvmProtocolTest.java
@@ -119,6 +119,8 @@ public void testIsInjvmRefer() throws Exception {
         url = URL.valueOf("fake://127.0.0.1/TestService").addParameter(GENERIC_KEY, true);
         assertFalse(InjvmProtocol.getInjvmProtocol().isInjvmRefer(url));
 
+        url = URL.valueOf("fake://127.0.0.1/TestService").addParameter("cluster", "broadcast");
+        assertFalse(InjvmProtocol.getInjvmProtocol().isInjvmRefer(url));
     }
 
 

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,8 @@ public void testIsInjvmRefer() throws Exception {`
`119`	`119`	`url = URL.valueOf("fake://127.0.0.1/TestService").addParameter(GENERIC_KEY, true);`
`120`	`120`	`assertFalse(InjvmProtocol.getInjvmProtocol().isInjvmRefer(url));`
`121`	`121`
	`122`	`+ url = URL.valueOf("fake://127.0.0.1/TestService").addParameter("cluster", "broadcast");`
	`123`	`+ assertFalse(InjvmProtocol.getInjvmProtocol().isInjvmRefer(url));`
`122`	`124`	`}`
`123`	`125`
`124`	`126`