Skip to content

Vectorize the DataSketches quantiles aggregator.#11183

Merged
clintropolis merged 2 commits intoapache:masterfrom
gianm:query-vectorize-quantiles-ds
May 2, 2021
Merged

Vectorize the DataSketches quantiles aggregator.#11183
clintropolis merged 2 commits intoapache:masterfrom
gianm:query-vectorize-quantiles-ds

Conversation

@gianm
Copy link
Contributor

@gianm gianm commented Apr 29, 2021

Also removes synchronization for the BufferAggregator and VectorAggregator
implementations, since it is not necessary (similar to #11115).

Extends DoublesSketchAggregatorTest and DoublesSketchSqlAggregatorTest
to run all test cases in vectorized mode.

Benchmarks from a group by query:

Benchmark              (query)  (rowsPerSegment)  (vectorize)  Mode  Cnt   Score   Error  Units
SqlBenchmark.querySql        1            500000        false  avgt   15  41.275 ± 2.392  ms/op
SqlBenchmark.querySql        1            500000        force  avgt   15  31.584 ± 1.052  ms/op

Also removes synchronization for the BufferAggregator and VectorAggregator
implementations, since it is not necessary (similar to apache#11115).

Extends DoublesSketchAggregatorTest and DoublesSketchSqlAggregatorTest
to run all test cases in vectorized mode.
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@clintropolis clintropolis merged commit 809e001 into apache:master May 2, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
@gianm gianm deleted the query-vectorize-quantiles-ds branch September 23, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants