[Enhance] [Binlog] Reduce thread number of SyncJob to save resources #6418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Aug 23, 2021
|
|
||
| private static final ExecutorService executor = new StripedTaskExecutor(); | ||
|
|
||
| public SyncTaskPool() { |
| /** | ||
| * max num of thread to handle sync task in sync task thread-pool. | ||
| */ | ||
| @ConfField public static int max_sync_task_threads_num = 1024; |
Contributor
There was a problem hiding this comment.
Why need so many threads here?
morningman
reviewed
Aug 31, 2021
Contributor
morningman
left a comment
There was a problem hiding this comment.
Please add UT for SyncTaskPool
| // column names of source table | ||
| @SerializedName(value = "colNames") | ||
| private final List<String> colNames; | ||
| @SerializedName(value = "id") |
Contributor
There was a problem hiding this comment.
use same name as variables
| SerialExecutor serialEx = slots[index]; | ||
| serialEx.execute(command); | ||
| } else { | ||
| taskPool.execute(command); |
Contributor
There was a problem hiding this comment.
Do we need to accept task without index in this pool?
Member
Author
There was a problem hiding this comment.
It‘s for compatibility with general thread pools
| private static final Logger LOG = LogManager.getLogger(SyncTask.class); | ||
|
|
||
| protected long signature; | ||
| protected int index; |
Contributor
There was a problem hiding this comment.
Add comment to explain the index
fcfb28e to
faa6625
Compare
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
#6417
This commit is going to reduce thread number of SyncJob .
1、Submit send task to thread pool to send data.
2、Submit eof task to thread pool to block and wake up client to commit transactions.
3、Use SerialExecutorService to ensure correct order of sent data in every channel.
Besides，some bugs have been fixed in this commit
1、Failed to resume syncJob.
2、Failed to do sync data when set multiple tables in a syncJob.
3、In a cluster with multiple Fe, master may hang up after creating syncJob.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...