[fix](tablet report)Replace tablet report with ForkJoinPool (#57382) #58714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…57382) Currently, tablet report logic uses a ForkJoinPool to process tablet information, but often encounters unexplained hangs in the ForkJoinPool. The printed stack trace doesn't reveal where the hang occurs, making it difficult to troubleshoot the issue. use forkjoin pool, report stuck stack such as ``` "report-thread" apache#187 daemon prio=5 os_prio=0 cpu=97864.95ms elapsed=2469428.50s tid=0x00007ff1cb5c8530 nid=0xef2 waiting on condition [0x00007fef462e1000] java.lang.Thread.State: WAITING (parking) at jdk.internal.misc.Unsafe.park(java.base@17.0.15/Native Method) - parking to wait for <0x00000006dc3fae00> (a java.util.concurrent.ForkJoinTask$AdaptedRunnableAction) at java.util.concurrent.locks.LockSupport.park(java.base@17.0.15/LockSupport.java:341) at java.util.concurrent.ForkJoinTask.awaitDone(java.base@17.0.15/ForkJoinTask.java:468) at java.util.concurrent.ForkJoinTask.join(java.base@17.0.15/ForkJoinTask.java:670) at org.apache.doris.catalog.TabletInvertedIndex.tabletReport(TabletInvertedIndex.java:370) at org.apache.doris.master.ReportHandler.tabletReport(ReportHandler.java:509) at org.apache.doris.master.ReportHandler$ReportTask.exec(ReportHandler.java:339) at org.apache.doris.master.ReportHandler.runOneCycle(ReportHandler.java:1466) at org.apache.doris.common.util.Daemon.run(Daemon.java:119) Locked ownable synchronizers: - None ``` Can't find where the problem is in this stack When the tablet report is stuck, the TabletInvertedIndex holds a read lock, leading to a deadlock. This pr uses a normal thread pool to replace forkjoinpool
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tablet report logic uses a ForkJoinPool to process tablet information, but often encounters unexplained hangs in the ForkJoinPool. The printed stack trace doesn't reveal where the hang occurs, making it difficult to troubleshoot the issue.
use forkjoin pool, report stuck stack such as
Can't find where the problem is in this stack
When the tablet report is stuck, the TabletInvertedIndex holds a read lock, leading to a deadlock.
This pr uses a normal thread pool to replace forkjoinpool
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)