Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #56639

… cache and change catalog properties (#56639)

The `resetToUninitialized` method should only be called when altering catalog properties, as it resets the entire catalog to an uninitialized state. Previously, `resetToUninitialized` was mistakenly called in `refreshMgr`. Refresh should only refresh the cache, not the entire catalog. Resetting the entire catalog could cause certain clients to shut down during a cache refresh, leading to errors.

This PR mainly changes:
1. Change the `onRefreshCache()` method
    This method will invalid db/table names cache and all meta cache
2. For `refresh` and `hms listener`, only call `onRefreshCache()`
3. For `alter catalog`, call `resetToUninitialized()`

TODO:
There is still a problem when we `alter catalog`, the ongoing task may be failed or stucked.
@github-actions github-actions bot requested a review from yiguolei as a code owner October 28, 2025 03:53
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 28, 2025
@hello-stephen
Copy link
Contributor

run buildall

@yiguolei yiguolei merged commit 6a1f031 into branch-4.0 Oct 28, 2025
24 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-56639-branch-4.0 branch October 28, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants