Skip to content

branch-4.0: [fix](nereids)fix sync mv parse error if it contains sql KEYWORD #57052 #57190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 22, 2025
Merged

branch-4.0: [fix](nereids)fix sync mv parse error if it contains sql KEYWORD #57052 #57190

yiguolei merged 1 commit into from
Oct 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 21, 2025

Cherry-picked from #57052

@starocean999
[fix](nereids)fix sync mv parse error if it contains sql KEYWORD (#57052
b1336e4 
)

```
create table t1_dup (
            `install` int,
            ```install``` int,
            c1 int
        );
alter table t1_dup add rollup r1(```install```, `install`);

// the sync mv parser will throw exception because install is a keyword should be in backquote as `install`
select ```install```, `install` from t1_dup; 
```
@github-actions github-actions bot requested a review from yiguolei as a code owner October 21, 2025 08:13
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 21, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 21, 2025

ClickBench: Total hot run time: 30.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b1336e41573aa733e83f683aa3667f7a5158bfd1, data reload: true

query1	0.04	0.04	0.03
query2	0.12	0.04	0.03
query3	0.24	0.08	0.07
query4	1.63	0.11	0.11
query5	0.28	0.26	0.26
query6	1.18	0.67	0.66
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.62	0.53	0.53
query10	0.62	0.58	0.59
query11	0.17	0.11	0.11
query12	0.16	0.13	0.12
query13	0.65	0.61	0.62
query14	0.80	0.86	0.83
query15	0.87	0.90	0.89
query16	0.40	0.41	0.41
query17	1.04	1.15	1.07
query18	0.19	0.19	0.20
query19	1.97	1.88	1.86
query20	0.03	0.02	0.01
query21	15.43	0.98	0.61
query22	0.79	1.28	0.65
query23	15.01	1.41	0.64
query24	6.57	1.14	0.46
query25	0.19	0.34	0.09
query26	0.66	0.17	0.14
query27	0.06	0.05	0.04
query28	10.26	1.45	0.95
query29	12.64	4.14	3.42
query30	0.29	0.14	0.11
query31	3.18	0.67	0.44
query32	3.53	0.60	0.50
query33	3.36	3.26	3.31
query34	16.97	5.75	5.15
query35	5.16	5.12	5.47
query36	0.70	0.52	0.61
query37	0.11	0.08	0.07
query38	0.09	0.05	0.05
query39	0.03	0.02	0.02
query40	0.18	0.15	0.14
query41	0.09	0.03	0.02
query42	0.04	0.02	0.03
query43	0.05	0.04	0.03
Total cold run time: 106.49 s
Total hot run time: 30.88 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 22, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit 3fb46e5 into branch-4.0 Oct 22, 2025
25 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-57052-branch-4.0 branch October 22, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @yiguolei @dataroaring @starocean999