Skip to content

branch-3.0: [fix](nereids)ReorderJoin rule should not absorb mark join to multi join #56837 #56981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liutang123 merged 1 commit into from
Oct 16, 2025
Merged

branch-3.0: [fix](nereids)ReorderJoin rule should not absorb mark join to multi join #56837 #56981

liutang123 merged 1 commit into from
Oct 16, 2025

Conversation

@liutang123
Copy link
Contributor

@liutang123 liutang123 commented Oct 15, 2025

Cherry-picked from #56837

@Thearas
Copy link
Contributor

Thearas commented Oct 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liutang123 liutang123 changed the base branch from master to branch-3.0 October 15, 2025 03:31
@liutang123
Copy link
Contributor Author

liutang123 commented Oct 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

TPC-H: Total hot run time: 39804 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e86598bb74d6da3c9e1b5f9255b01a1db84bb0b0, data reload: false

------ Round 1 ----------------------------------
q1	17600	6824	6692	6692
q2	2017	204	186	186
q3	10506	1127	1183	1127
q4	10218	726	715	715
q5	7732	2828	2885	2828
q6	215	131	127	127
q7	974	628	605	605
q8	9358	1927	1987	1927
q9	6627	6413	6438	6413
q10	6988	2252	2337	2252
q11	463	258	251	251
q12	405	210	214	210
q13	17813	2970	2982	2970
q14	246	212	215	212
q15	516	451	468	451
q16	464	376	374	374
q17	985	537	575	537
q18	7239	6601	6780	6601
q19	1403	1166	1032	1032
q20	479	193	199	193
q21	3997	3105	3193	3105
q22	1123	1014	996	996
Total cold run time: 107368 ms
Total hot run time: 39804 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6641	6616	6622	6616
q2	335	233	231	231
q3	2886	2897	2898	2897
q4	2048	1768	1838	1768
q5	5752	5701	5672	5672
q6	209	123	126	123
q7	2247	1804	1819	1804
q8	3419	3564	3574	3564
q9	8801	8934	8905	8905
q10	3528	3519	3545	3519
q11	588	495	492	492
q12	801	612	622	612
q13	8449	3164	3139	3139
q14	308	269	265	265
q15	509	460	465	460
q16	507	432	420	420
q17	1863	1629	1630	1629
q18	8129	7830	7880	7830
q19	1708	1543	1481	1481
q20	2053	1812	1825	1812
q21	5265	5017	5017	5017
q22	1125	1061	1004	1004
Total cold run time: 67171 ms
Total hot run time: 59260 ms

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

TPC-DS: Total hot run time: 193312 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e86598bb74d6da3c9e1b5f9255b01a1db84bb0b0, data reload: false

query1	964	378	374	374
query2	6307	1922	1907	1907
query3	8684	201	198	198
query4	33865	23450	23950	23450
query5	3923	456	435	435
query6	280	178	174	174
query7	4209	311	311	311
query8	295	222	231	222
query9	9566	2600	2579	2579
query10	488	300	265	265
query11	17978	15199	15596	15199
query12	166	107	104	104
query13	1592	415	426	415
query14	10843	7540	7276	7276
query15	255	172	175	172
query16	8027	561	516	516
query17	1648	613	601	601
query18	2233	316	320	316
query19	368	163	169	163
query20	126	119	118	118
query21	208	110	105	105
query22	4756	4507	4414	4414
query23	34675	34603	33824	33824
query24	11181	2952	2985	2952
query25	627	441	422	422
query26	743	175	176	175
query27	2170	354	352	352
query28	6406	2196	2210	2196
query29	792	466	467	466
query30	262	164	164	164
query31	1062	831	846	831
query32	98	60	62	60
query33	765	327	305	305
query34	923	509	520	509
query35	848	736	745	736
query36	1125	952	966	952
query37	125	69	69	69
query38	4040	3996	4002	3996
query39	1540	1477	1479	1477
query40	202	102	99	99
query41	50	49	50	49
query42	112	106	106	106
query43	537	491	489	489
query44	1222	852	850	850
query45	192	175	171	171
query46	1190	730	752	730
query47	2018	1950	1953	1950
query48	485	406	391	391
query49	930	392	410	392
query50	862	435	417	417
query51	7417	7325	7287	7287
query52	105	97	97	97
query53	270	193	193	193
query54	1343	501	461	461
query55	80	79	77	77
query56	267	258	256	256
query57	1316	1198	1212	1198
query58	215	204	212	204
query59	3162	3076	3082	3076
query60	291	264	286	264
query61	109	112	119	112
query62	842	702	690	690
query63	237	191	199	191
query64	4459	754	647	647
query65	3375	3319	3290	3290
query66	799	300	290	290
query67	16082	15583	15654	15583
query68	4553	599	586	586
query69	443	274	268	268
query70	1197	1119	1138	1119
query71	345	293	259	259
query72	6396	4091	4033	4033
query73	745	341	357	341
query74	10396	9371	9317	9317
query75	3363	2656	2651	2651
query76	2671	1029	1014	1014
query77	384	272	278	272
query78	10533	9619	9641	9619
query79	2669	624	605	605
query80	990	425	431	425
query81	539	216	219	216
query82	602	91	94	91
query83	244	140	142	140
query84	244	82	81	81
query85	1214	322	300	300
query86	419	298	305	298
query87	4349	4248	4231	4231
query88	4220	2396	2365	2365
query89	406	290	289	289
query90	1960	187	188	187
query91	189	147	157	147
query92	60	49	49	49
query93	2356	558	557	557
query94	800	286	306	286
query95	357	266	259	259
query96	624	284	284	284
query97	3322	3243	3176	3176
query98	218	202	191	191
query99	1531	1296	1342	1296
Total cold run time: 300671 ms
Total hot run time: 193312 ms

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

ClickBench: Total hot run time: 29.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e86598bb74d6da3c9e1b5f9255b01a1db84bb0b0, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.02
query3	0.22	0.06	0.06
query4	1.63	0.11	0.10
query5	0.54	0.54	0.53
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.57	0.51	0.50
query10	0.55	0.57	0.55
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.60	0.60	0.59
query14	0.79	0.80	0.78
query15	0.84	0.82	0.82
query16	0.39	0.40	0.38
query17	1.03	1.00	1.00
query18	0.23	0.21	0.22
query19	1.99	1.88	1.89
query20	0.01	0.01	0.02
query21	15.39	0.60	0.57
query22	2.33	2.03	1.22
query23	17.10	1.02	0.85
query24	3.33	1.55	0.99
query25	0.20	0.09	0.07
query26	0.46	0.13	0.14
query27	0.04	0.03	0.05
query28	9.73	0.49	0.51
query29	12.58	3.21	3.20
query30	0.26	0.07	0.06
query31	2.85	0.39	0.37
query32	3.27	0.47	0.46
query33	3.00	3.03	3.02
query34	16.98	4.50	4.52
query35	4.55	4.56	4.57
query36	0.66	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 104.18 s
Total hot run time: 29.72 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 15, 2025

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@liutang123
Copy link
Contributor Author

liutang123 commented Oct 15, 2025

run nonConcurrent

2 similar comments
@liutang123
Copy link
Contributor Author

liutang123 commented Oct 15, 2025

run nonConcurrent

@liutang123
Copy link
Contributor Author

liutang123 commented Oct 15, 2025

run nonConcurrent

lide-reed
lide-reed approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

PR approved by anyone and no changes requested.

@liutang123 liutang123 merged commit a70eed3 into apache:branch-3.0 Oct 16, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liutang123 @Thearas @doris-robot @hello-stephen @lide-reed @starocean999