Skip to content

branch-3.1: [fix](nereids)ReorderJoin rule should not absorb mark join to multi join #56837 #56906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 15, 2025
Merged

branch-3.1: [fix](nereids)ReorderJoin rule should not absorb mark join to multi join #56837 #56906

morrySnow merged 1 commit into from
Oct 15, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 13, 2025

Cherry-picked from #56837

@github-actions github-actions bot requested a review from morrySnow as a code owner October 13, 2025 08:00
@Thearas
Copy link
Contributor

Thearas commented Oct 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 13, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-H: Total hot run time: 32910 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c354079e1406b7dee191a02e8a636f919eb6b5c0, data reload: false

------ Round 1 ----------------------------------
q1	17590	5476	5408	5408
q2	2038	393	283	283
q3	12295	1234	738	738
q4	10501	859	446	446
q5	9486	2375	2134	2134
q6	184	164	130	130
q7	902	741	601	601
q8	9334	1407	1155	1155
q9	5191	5026	4914	4914
q10	6755	2276	1819	1819
q11	476	290	255	255
q12	342	345	206	206
q13	17774	3605	2986	2986
q14	217	215	212	212
q15	516	468	463	463
q16	437	437	368	368
q17	618	854	385	385
q18	6951	6572	6729	6572
q19	1209	973	563	563
q20	344	349	209	209
q21	3090	2244	2054	2054
q22	1088	1078	1009	1009
Total cold run time: 107338 ms
Total hot run time: 32910 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5443	5443	5436	5436
q2	239	329	246	246
q3	2302	2641	2271	2271
q4	1309	1787	1361	1361
q5	4394	5013	4967	4967
q6	172	166	129	129
q7	2069	1949	1800	1800
q8	2629	2797	2708	2708
q9	7255	7244	7167	7167
q10	3046	3228	2786	2786
q11	583	494	488	488
q12	706	766	585	585
q13	3349	3804	3174	3174
q14	275	302	263	263
q15	523	474	465	465
q16	456	467	430	430
q17	1268	1716	1252	1252
q18	7604	7578	7332	7332
q19	821	1097	1058	1058
q20	1991	2055	1946	1946
q21	5241	4930	4470	4470
q22	1101	1107	1015	1015
Total cold run time: 52776 ms
Total hot run time: 51349 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-DS: Total hot run time: 192494 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c354079e1406b7dee191a02e8a636f919eb6b5c0, data reload: false

query1	933	404	411	404
query2	6208	1878	1861	1861
query3	8687	219	210	210
query4	33695	23831	23529	23529
query5	3690	586	443	443
query6	310	190	169	169
query7	4213	481	321	321
query8	296	244	227	227
query9	9409	2607	2625	2607
query10	469	319	261	261
query11	18131	15560	15560	15560
query12	158	106	114	106
query13	1562	537	409	409
query14	10099	6671	6962	6671
query15	222	194	191	191
query16	7980	640	501	501
query17	1544	760	621	621
query18	2129	428	328	328
query19	225	191	174	174
query20	127	123	123	123
query21	210	135	107	107
query22	4658	4603	4402	4402
query23	34674	34619	33749	33749
query24	7335	2706	2734	2706
query25	536	504	451	451
query26	1195	307	183	183
query27	2144	472	359	359
query28	5407	2275	2191	2191
query29	763	600	462	462
query30	236	193	164	164
query31	1000	915	834	834
query32	90	64	61	61
query33	530	389	325	325
query34	747	851	544	544
query35	805	815	739	739
query36	1001	1051	962	962
query37	108	92	66	66
query38	4042	4108	4047	4047
query39	1568	1504	1490	1490
query40	210	116	109	109
query41	50	50	48	48
query42	132	112	112	112
query43	526	526	481	481
query44	1296	861	838	838
query45	189	194	179	179
query46	919	1064	677	677
query47	2001	2000	1932	1932
query48	410	431	376	376
query49	769	511	432	432
query50	692	687	448	448
query51	7386	7374	7261	7261
query52	104	104	95	95
query53	232	266	189	189
query54	562	548	481	481
query55	82	82	84	82
query56	273	282	268	268
query57	1250	1262	1243	1243
query58	232	230	225	225
query59	3044	3145	3115	3115
query60	297	279	265	265
query61	116	114	120	114
query62	841	747	709	709
query63	231	200	199	199
query64	4464	1029	629	629
query65	3320	3320	3271	3271
query66	978	420	316	316
query67	16115	15743	15480	15480
query68	7599	809	548	548
query69	493	305	271	271
query70	1177	1147	1133	1133
query71	368	303	266	266
query72	5670	3737	3910	3737
query73	638	746	359	359
query74	10314	9395	9221	9221
query75	3222	3066	2633	2633
query76	3090	1171	765	765
query77	512	368	278	278
query78	10472	10510	9647	9647
query79	3455	896	598	598
query80	641	524	437	437
query81	502	257	226	226
query82	577	120	93	93
query83	172	159	148	148
query84	237	97	83	83
query85	809	345	340	340
query86	402	327	277	277
query87	4375	4341	4249	4249
query88	5124	2396	2502	2396
query89	404	328	296	296
query90	1852	192	190	190
query91	137	152	107	107
query92	67	55	52	52
query93	2116	904	557	557
query94	692	385	301	301
query95	350	289	273	273
query96	495	608	286	286
query97	3171	3271	3079	3079
query98	230	214	209	209
query99	1627	1400	1307	1307
Total cold run time: 294847 ms
Total hot run time: 192494 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 28.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c354079e1406b7dee191a02e8a636f919eb6b5c0, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.02	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.10
query5	0.53	0.51	0.51
query6	1.13	0.75	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.51
query10	0.55	0.56	0.55
query11	0.14	0.11	0.11
query12	0.13	0.10	0.11
query13	0.63	0.60	0.59
query14	0.79	0.80	0.79
query15	0.83	0.83	0.82
query16	0.40	0.39	0.41
query17	1.01	1.00	1.02
query18	0.24	0.22	0.22
query19	1.88	1.90	1.87
query20	0.02	0.01	0.01
query21	15.41	0.87	0.56
query22	0.74	0.89	0.65
query23	15.04	1.42	0.58
query24	2.92	0.42	1.09
query25	0.15	0.22	0.08
query26	0.47	0.14	0.13
query27	0.04	0.04	0.05
query28	13.27	1.02	0.44
query29	12.59	4.03	3.37
query30	0.25	0.09	0.07
query31	2.81	0.58	0.38
query32	3.23	0.54	0.45
query33	3.01	3.01	3.01
query34	16.64	5.12	4.53
query35	4.54	4.58	4.58
query36	0.62	0.51	0.47
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.06 s
Total hot run time: 28.53 s

@morrySnow morrySnow merged commit 0951167 into branch-3.1 Oct 15, 2025
23 checks passed
@morrySnow morrySnow deleted the auto-pick-56837-branch-3.1 branch October 15, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @morrySnow @dataroaring @starocean999