Skip to content

branch-4.0: [opt](nereids) optimize bs downgrade alg. #56279 #56889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 14, 2025
Merged

branch-4.0: [opt](nereids) optimize bs downgrade alg. #56279 #56889

yiguolei merged 1 commit into from
Oct 14, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 13, 2025

Cherry-picked from #56279

@englefly
[opt](nereids) optimize bs downgrade alg. (#56279)
82e6293 
### What problem does this PR solve?
PR#36784: Bucket shuffle join shall be disabled if the number of scan
instances for the left table of the join is less than 10.
The value "10" should not be hardcoded here; instead, it should be
calculated based on the cluster size. This PR will replace the fixed
value "10" with a dynamic value equal to 0.8 times the maximum
concurrency of the cluster.
@github-actions github-actions bot requested a review from yiguolei as a code owner October 13, 2025 03:43
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 13, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 29.96 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 82e62938da7cac6621f5a558f73656e1752af32a, data reload: true

query1	0.03	0.04	0.03
query2	0.10	0.04	0.03
query3	0.28	0.07	0.07
query4	1.74	0.10	0.11
query5	0.27	0.25	0.25
query6	1.26	0.65	0.66
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.62	0.52	0.50
query10	0.57	0.58	0.57
query11	0.18	0.11	0.11
query12	0.16	0.11	0.11
query13	0.63	0.62	0.61
query14	0.81	0.83	0.82
query15	0.89	0.85	0.86
query16	0.41	0.39	0.39
query17	1.06	1.04	1.05
query18	0.19	0.19	0.18
query19	1.91	1.81	1.78
query20	0.02	0.01	0.01
query21	15.44	0.90	0.56
query22	0.79	0.97	0.74
query23	15.22	1.34	0.62
query24	4.87	0.76	0.31
query25	0.23	0.05	0.07
query26	0.59	0.15	0.14
query27	0.06	0.05	0.04
query28	11.79	1.45	0.92
query29	12.72	3.95	3.34
query30	0.31	0.13	0.11
query31	3.00	0.59	0.38
query32	3.31	0.54	0.46
query33	3.03	3.17	3.29
query34	18.41	5.86	5.03
query35	5.04	5.13	5.07
query36	0.71	0.53	0.54
query37	0.09	0.06	0.06
query38	0.06	0.04	0.03
query39	0.03	0.03	0.03
query40	0.17	0.16	0.14
query41	0.09	0.02	0.02
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 107.25 s
Total hot run time: 29.96 s

@yiguolei yiguolei merged commit 302ba2e into branch-4.0 Oct 14, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @yiguolei @dataroaring @englefly