Skip to content

branch-3.1: [Fix](warmup) one-time and periodic warm up job should be triggered regardless whether the rowset has been warmed up before #56737 #56864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 13, 2025
Merged

branch-3.1: [Fix](warmup) one-time and periodic warm up job should be triggered regardless whether the rowset has been warmed up before #56737 #56864

morrySnow merged 1 commit into from
Oct 13, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 11, 2025

Cherry-picked from #56737

@bobhan1
[Fix](warmup) one-time and periodic warm up job should be triggered r…
89bcd75 
…egardless whether the rowset has been warmed up before (#56737)

### What problem does this PR solve?


Related PR: #54611
@github-actions github-actions bot requested a review from morrySnow as a code owner October 11, 2025 11:17
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 11, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

TPC-H: Total hot run time: 33034 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 89bcd750765d5c01778435cda2f13b13a222d12d, data reload: false

------ Round 1 ----------------------------------
q1	17595	5578	5427	5427
q2	2019	407	278	278
q3	12152	1278	753	753
q4	10287	883	458	458
q5	9101	2384	2130	2130
q6	181	163	133	133
q7	893	747	637	637
q8	9345	1455	1136	1136
q9	5253	4966	5233	4966
q10	6772	2272	1832	1832
q11	492	284	273	273
q12	360	357	223	223
q13	17786	3598	3003	3003
q14	224	240	237	237
q15	538	473	463	463
q16	430	420	368	368
q17	608	871	357	357
q18	7018	6490	6516	6490
q19	1208	945	552	552
q20	330	339	213	213
q21	2864	2184	2082	2082
q22	1053	1027	1023	1023
Total cold run time: 106509 ms
Total hot run time: 33034 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5532	5523	5510	5510
q2	238	330	234	234
q3	2255	2617	2297	2297
q4	1380	1836	1393	1393
q5	4421	4982	4995	4982
q6	170	165	130	130
q7	2116	1978	1788	1788
q8	2656	2933	2726	2726
q9	7355	7268	7319	7268
q10	3084	3292	2741	2741
q11	570	508	506	506
q12	665	745	607	607
q13	3453	3794	3158	3158
q14	276	312	276	276
q15	527	485	470	470
q16	420	485	450	450
q17	1245	1724	1263	1263
q18	7774	7425	7422	7422
q19	803	1127	1076	1076
q20	2011	2067	1930	1930
q21	5435	4988	4558	4558
q22	1114	1098	1009	1009
Total cold run time: 53500 ms
Total hot run time: 51794 ms

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

TPC-DS: Total hot run time: 192864 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 89bcd750765d5c01778435cda2f13b13a222d12d, data reload: false

query1	959	383	378	378
query2	6112	1979	1913	1913
query3	8684	207	205	205
query4	33638	23792	23395	23395
query5	3564	616	475	475
query6	291	197	182	182
query7	4211	504	326	326
query8	315	267	257	257
query9	9346	2631	2612	2612
query10	502	323	267	267
query11	17843	15476	15281	15281
query12	159	111	110	110
query13	1557	550	429	429
query14	9321	7371	7323	7323
query15	265	197	180	180
query16	8100	641	512	512
query17	1605	780	590	590
query18	2146	408	323	323
query19	212	180	157	157
query20	121	124	129	124
query21	205	141	115	115
query22	4599	4674	4671	4671
query23	35467	34820	33969	33969
query24	7680	2734	2702	2702
query25	508	470	420	420
query26	1155	280	173	173
query27	2068	483	371	371
query28	5197	2230	2208	2208
query29	703	590	478	478
query30	248	194	164	164
query31	963	942	839	839
query32	91	61	63	61
query33	547	373	331	331
query34	755	860	529	529
query35	812	818	747	747
query36	1026	1075	947	947
query37	109	102	73	73
query38	4022	3993	4145	3993
query39	1514	1475	1487	1475
query40	215	136	112	112
query41	58	53	55	53
query42	128	113	111	111
query43	527	529	505	505
query44	1323	836	840	836
query45	189	188	175	175
query46	909	1063	688	688
query47	1956	1993	1911	1911
query48	440	438	369	369
query49	842	505	438	438
query50	701	702	442	442
query51	7439	7452	7356	7356
query52	109	101	93	93
query53	230	267	201	201
query54	554	557	491	491
query55	89	82	88	82
query56	300	300	266	266
query57	1253	1245	1197	1197
query58	245	221	217	217
query59	3120	3340	3128	3128
query60	295	294	275	275
query61	115	113	109	109
query62	805	745	700	700
query63	239	191	197	191
query64	4444	1028	646	646
query65	3471	3352	3333	3333
query66	1014	411	319	319
query67	15980	15905	15807	15807
query68	7773	849	540	540
query69	478	315	270	270
query70	1214	1117	1147	1117
query71	399	299	290	290
query72	5609	3723	2547	2547
query73	653	737	348	348
query74	10175	9423	9146	9146
query75	3781	3177	2681	2681
query76	3344	1174	791	791
query77	781	386	287	287
query78	10370	10675	9814	9814
query79	3583	930	606	606
query80	727	544	445	445
query81	509	266	228	228
query82	588	125	89	89
query83	166	162	151	151
query84	236	95	87	87
query85	805	377	305	305
query86	399	311	283	283
query87	4338	4367	4303	4303
query88	5160	2431	2425	2425
query89	400	335	305	305
query90	1815	197	193	193
query91	139	142	111	111
query92	69	57	53	53
query93	2516	922	546	546
query94	649	408	303	303
query95	355	284	275	275
query96	493	625	287	287
query97	3187	3236	3191	3191
query98	241	212	199	199
query99	1355	1416	1292	1292
Total cold run time: 295917 ms
Total hot run time: 192864 ms

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

ClickBench: Total hot run time: 28.5 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 89bcd750765d5c01778435cda2f13b13a222d12d, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.25	0.06	0.07
query4	1.62	0.10	0.10
query5	0.53	0.49	0.50
query6	1.12	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.50	0.50
query10	0.55	0.56	0.55
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.62	0.60	0.59
query14	0.79	0.78	0.83
query15	0.87	0.83	0.83
query16	0.38	0.40	0.39
query17	1.03	1.09	1.04
query18	0.25	0.23	0.22
query19	1.92	1.90	1.83
query20	0.01	0.02	0.01
query21	15.39	0.90	0.60
query22	0.73	0.81	0.72
query23	15.05	1.40	0.57
query24	3.54	0.40	0.88
query25	0.24	0.10	0.05
query26	0.25	0.14	0.15
query27	0.05	0.04	0.04
query28	12.65	1.02	0.45
query29	12.56	3.99	3.25
query30	0.25	0.10	0.07
query31	2.81	0.61	0.40
query32	3.22	0.53	0.46
query33	3.02	3.04	3.07
query34	16.65	5.18	4.57
query35	4.66	4.53	4.53
query36	0.65	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.14 s
Total hot run time: 28.5 s

@morrySnow morrySnow merged commit d6a514e into branch-3.1 Oct 13, 2025
21 of 22 checks passed
@morrySnow morrySnow deleted the auto-pick-56737-branch-3.1 branch October 13, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @bobhan1