Skip to content

branch-3.1: [fix](ubsan) fix ub error of uninitialized variable #56854 #56855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 13, 2025
Merged

branch-3.1: [fix](ubsan) fix ub error of uninitialized variable #56854 #56855

morrySnow merged 1 commit into from
Oct 13, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 11, 2025

bp #56854

@morningman morningman requested a review from morrySnow as a code owner October 11, 2025 09:17
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Oct 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

TPC-H: Total hot run time: 32775 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2763ad5a835c8742154a6b9423d542f5b1a65de4, data reload: false

------ Round 1 ----------------------------------
q1	17610	5487	5459	5459
q2	2010	405	294	294
q3	12279	1246	774	774
q4	10554	869	460	460
q5	9650	2414	2143	2143
q6	192	163	131	131
q7	911	731	614	614
q8	9340	1444	1160	1160
q9	5264	4972	4933	4933
q10	6766	2276	1828	1828
q11	464	282	261	261
q12	333	353	216	216
q13	17781	3588	2977	2977
q14	231	223	211	211
q15	527	462	473	462
q16	423	432	368	368
q17	611	866	359	359
q18	6816	6531	6386	6386
q19	1193	969	537	537
q20	333	340	212	212
q21	2961	2147	1991	1991
q22	1080	1026	999	999
Total cold run time: 107329 ms
Total hot run time: 32775 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5760	5450	5488	5450
q2	240	336	239	239
q3	2244	2600	2279	2279
q4	1374	1809	1365	1365
q5	4429	5024	5017	5017
q6	167	176	133	133
q7	2111	1934	1837	1837
q8	2625	2833	2676	2676
q9	7324	7321	7242	7242
q10	3017	3229	2791	2791
q11	576	507	517	507
q12	639	743	607	607
q13	3424	3725	3220	3220
q14	276	302	288	288
q15	507	464	466	464
q16	436	484	454	454
q17	1223	1727	1283	1283
q18	7661	7443	7308	7308
q19	815	1095	1120	1095
q20	2016	2063	1930	1930
q21	5298	4947	4635	4635
q22	1053	1083	1019	1019
Total cold run time: 53215 ms
Total hot run time: 51839 ms

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

TPC-DS: Total hot run time: 192958 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2763ad5a835c8742154a6b9423d542f5b1a65de4, data reload: false

query1	944	401	406	401
query2	6262	1963	1899	1899
query3	8687	202	198	198
query4	33899	23681	23546	23546
query5	3648	582	458	458
query6	293	198	189	189
query7	4207	489	310	310
query8	293	232	225	225
query9	9462	2599	2590	2590
query10	476	319	267	267
query11	18149	15490	15158	15158
query12	170	108	110	108
query13	1556	557	420	420
query14	9290	6924	6737	6737
query15	248	186	180	180
query16	7908	660	547	547
query17	1564	766	600	600
query18	2054	438	355	355
query19	203	191	172	172
query20	127	129	125	125
query21	216	126	112	112
query22	4646	4629	4391	4391
query23	35658	35013	34255	34255
query24	7777	2718	2709	2709
query25	517	505	437	437
query26	1070	255	178	178
query27	2204	489	382	382
query28	5534	2252	2237	2237
query29	610	571	467	467
query30	237	194	177	177
query31	993	938	854	854
query32	84	59	60	59
query33	503	373	309	309
query34	744	860	522	522
query35	788	831	771	771
query36	1027	1038	954	954
query37	109	90	67	67
query38	4088	4048	4073	4048
query39	1548	1479	1486	1479
query40	216	126	106	106
query41	52	49	48	48
query42	130	121	105	105
query43	508	524	481	481
query44	1323	846	855	846
query45	193	186	175	175
query46	882	1069	689	689
query47	1990	2004	1951	1951
query48	405	435	359	359
query49	768	500	423	423
query50	691	687	430	430
query51	7443	7415	7323	7323
query52	110	98	91	91
query53	237	254	189	189
query54	556	558	491	491
query55	81	80	83	80
query56	281	276	260	260
query57	1274	1290	1239	1239
query58	239	230	226	226
query59	3085	3164	3051	3051
query60	290	293	280	280
query61	118	118	111	111
query62	806	752	685	685
query63	235	191	208	191
query64	4351	1035	645	645
query65	3416	3284	3320	3284
query66	969	423	310	310
query67	16387	15704	15545	15545
query68	7756	825	549	549
query69	477	306	274	274
query70	1202	1145	1134	1134
query71	377	293	266	266
query72	5719	3771	3728	3728
query73	638	745	359	359
query74	10572	9507	9314	9314
query75	3200	3140	2688	2688
query76	3215	1143	750	750
query77	730	383	274	274
query78	10392	10476	9587	9587
query79	3043	896	598	598
query80	708	521	448	448
query81	513	268	225	225
query82	546	121	95	95
query83	188	165	148	148
query84	282	101	81	81
query85	775	361	296	296
query86	344	310	287	287
query87	4378	4371	4198	4198
query88	4824	2461	2434	2434
query89	411	340	301	301
query90	1854	193	193	193
query91	136	146	110	110
query92	67	55	53	53
query93	1324	922	552	552
query94	682	416	298	298
query95	354	278	276	276
query96	496	615	285	285
query97	3194	3257	3143	3143
query98	232	218	203	203
query99	1548	1395	1304	1304
Total cold run time: 295006 ms
Total hot run time: 192958 ms

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

ClickBench: Total hot run time: 28.71 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2763ad5a835c8742154a6b9423d542f5b1a65de4, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.62	0.11	0.11
query5	0.53	0.51	0.52
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.58	0.51	0.49
query10	0.56	0.55	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	0.78	0.83	0.78
query15	0.84	0.84	0.83
query16	0.39	0.39	0.42
query17	0.96	1.03	1.00
query18	0.25	0.23	0.22
query19	1.86	1.81	1.85
query20	0.02	0.01	0.01
query21	15.40	0.97	0.58
query22	0.75	0.68	0.60
query23	15.25	1.48	0.55
query24	3.47	1.59	0.93
query25	0.24	0.07	0.20
query26	0.20	0.14	0.14
query27	0.07	0.06	0.05
query28	13.84	0.96	0.46
query29	12.55	3.91	3.22
query30	0.25	0.09	0.06
query31	2.84	0.58	0.37
query32	3.22	0.53	0.46
query33	3.01	2.99	3.04
query34	16.39	5.13	4.50
query35	4.53	4.58	4.65
query36	0.66	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.03
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 103.91 s
Total hot run time: 28.71 s

@morrySnow morrySnow merged commit ad5874b into apache:branch-3.1 Oct 13, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman @hello-stephen @doris-robot @morrySnow