Skip to content

branch-4.0: [fix](mow) delete bitmap is not deleted if commit compaction job failed #56758 #56779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 11, 2025
Merged

branch-4.0: [fix](mow) delete bitmap is not deleted if commit compaction job failed #56758 #56779

yiguolei merged 1 commit into from
Oct 11, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2025

Cherry-picked from #56758

@mymeiyi
[fix](mow) delete bitmap is not deleted if commit compaction job fail…
29cb54b 
…ed (#56758)

delete bitmap kv is leaked:
```
[delete bitmap check fails] can't find corresponding rowset for delete bitmap instance_id=113100978, tablet_id=1759979382398, rowset_id=0200000000000027bc46eb5855e1afdc75b79046710c329f, version=13, segment_id=0
```
this is because: 
1. when update delete bitmap for  compaction, does not write pending key
2. when commit compaction job failed, the delete bitmap kv is not
deleted
3. when delete tmp rowset kv, the delete bitmap kv is not deleted
@github-actions github-actions bot requested a review from yiguolei as a code owner October 10, 2025 03:56
@Thearas
Copy link
Contributor

Thearas commented Oct 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 10, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 10, 2025

ClickBench: Total hot run time: 30.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 29cb54b75ef5595c03094a69673ec18d7ad8dbc0, data reload: true

query1	0.04	0.02	0.03
query2	0.11	0.04	0.03
query3	0.27	0.07	0.09
query4	1.73	0.12	0.11
query5	0.28	0.25	0.24
query6	1.25	0.65	0.66
query7	0.02	0.03	0.02
query8	0.06	0.04	0.04
query9	0.61	0.52	0.52
query10	0.56	0.56	0.58
query11	0.18	0.10	0.11
query12	0.16	0.12	0.12
query13	0.64	0.62	0.61
query14	0.80	0.84	0.82
query15	0.90	0.86	0.87
query16	0.38	0.39	0.40
query17	1.05	1.05	1.07
query18	0.20	0.20	0.19
query19	1.92	1.82	1.87
query20	0.02	0.01	0.01
query21	15.44	0.90	0.59
query22	0.79	1.05	0.79
query23	15.25	1.39	0.57
query24	16.29	1.44	0.63
query25	2.25	0.40	0.20
query26	0.19	0.18	0.18
query27	0.21	0.21	0.20
query28	1.81	1.03	0.95
query29	12.74	3.93	3.23
query30	0.31	0.12	0.11
query31	3.01	0.58	0.40
query32	3.30	0.56	0.49
query33	3.08	3.11	3.14
query34	17.06	5.91	5.05
query35	5.12	5.25	5.08
query36	0.72	0.56	0.53
query37	0.10	0.07	0.06
query38	0.05	0.03	0.04
query39	0.04	0.03	0.03
query40	0.19	0.15	0.15
query41	0.10	0.02	0.02
query42	0.04	0.02	0.03
query43	0.05	0.03	0.03
Total cold run time: 109.32 s
Total hot run time: 30.68 s

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 11, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 11, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 1bd31df into branch-4.0 Oct 11, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @yiguolei @dataroaring @mymeiyi