Skip to content

branch-3.1: [fix](filecache) fix crash when clear file cache #56170 #56761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 13, 2025
Merged

branch-3.1: [fix](filecache) fix crash when clear file cache #56170 #56761

morrySnow merged 1 commit into from
Oct 13, 2025

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Oct 9, 2025 •
edited by morrySnow
Loading

picked from #56170

@freemandealer
[fix](filecache) fix crash when clear file cache (apache#56170)
267054d 
_need_update_lru_blocks holds the reference of the block which will be
cleared by api/op=clear thus causing use-after-free
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

freemandealer commented Oct 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 9, 2025

TPC-H: Total hot run time: 33116 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 267054d9c1529af4281deef5259e8bf46fe18f1a, data reload: false

------ Round 1 ----------------------------------
q1	17597	5582	5526	5526
q2	2046	409	306	306
q3	12059	1247	749	749
q4	10229	893	463	463
q5	7818	2407	2180	2180
q6	186	173	143	143
q7	938	753	626	626
q8	9327	1479	1207	1207
q9	5344	5031	5074	5031
q10	6777	2269	1844	1844
q11	472	289	267	267
q12	342	361	214	214
q13	17792	3592	2994	2994
q14	237	233	212	212
q15	524	475	464	464
q16	427	433	375	375
q17	594	892	367	367
q18	7033	6411	6428	6411
q19	1501	962	567	567
q20	348	346	210	210
q21	2963	2359	2002	2002
q22	1071	1041	958	958
Total cold run time: 105625 ms
Total hot run time: 33116 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5593	5591	5776	5591
q2	234	332	235	235
q3	2240	2631	2298	2298
q4	1400	1826	1431	1431
q5	4446	5024	5000	5000
q6	171	169	132	132
q7	2127	1980	1836	1836
q8	2695	2871	2746	2746
q9	7273	7238	7214	7214
q10	3068	3338	2684	2684
q11	563	509	478	478
q12	642	736	614	614
q13	3398	3830	3121	3121
q14	291	293	278	278
q15	522	478	483	478
q16	437	476	439	439
q17	1260	1781	1252	1252
q18	7459	7423	7468	7423
q19	848	839	1196	839
q20	2006	2081	1881	1881
q21	5509	4919	4545	4545
q22	1130	1056	1010	1010
Total cold run time: 53312 ms
Total hot run time: 51525 ms

@doris-robot
Copy link

doris-robot commented Oct 9, 2025

TPC-DS: Total hot run time: 192526 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 267054d9c1529af4281deef5259e8bf46fe18f1a, data reload: false

query1	981	409	385	385
query2	6221	2033	1919	1919
query3	8680	206	208	206
query4	33910	23903	23573	23573
query5	3704	617	457	457
query6	278	196	180	180
query7	4191	495	308	308
query8	324	262	267	262
query9	9181	2614	2604	2604
query10	479	325	261	261
query11	18028	15463	15648	15463
query12	153	111	110	110
query13	1573	560	418	418
query14	10361	7888	6774	6774
query15	240	200	186	186
query16	8095	670	468	468
query17	1569	773	631	631
query18	2151	412	324	324
query19	235	195	174	174
query20	122	120	124	120
query21	207	137	109	109
query22	4509	4542	4435	4435
query23	34996	34025	34132	34025
query24	7348	2716	2780	2716
query25	552	492	448	448
query26	1174	298	180	180
query27	2121	495	361	361
query28	5265	2235	2236	2235
query29	799	622	472	472
query30	250	195	158	158
query31	1016	949	840	840
query32	88	59	57	57
query33	494	371	332	332
query34	743	874	545	545
query35	793	802	739	739
query36	1024	1075	986	986
query37	113	96	72	72
query38	4027	4001	3977	3977
query39	1511	1483	1482	1482
query40	216	116	103	103
query41	51	54	50	50
query42	128	107	108	107
query43	533	536	486	486
query44	1397	866	841	841
query45	180	181	175	175
query46	898	1082	698	698
query47	1996	1987	1911	1911
query48	416	425	362	362
query49	785	500	401	401
query50	674	699	435	435
query51	7342	7357	7189	7189
query52	109	104	94	94
query53	240	270	195	195
query54	540	552	477	477
query55	80	84	83	83
query56	269	275	262	262
query57	1298	1284	1195	1195
query58	237	220	218	218
query59	3117	3212	3019	3019
query60	296	289	260	260
query61	120	144	114	114
query62	796	771	723	723
query63	239	206	207	206
query64	4785	984	632	632
query65	3383	3301	3348	3301
query66	1193	427	322	322
query67	16757	15800	15530	15530
query68	7492	840	539	539
query69	483	311	269	269
query70	1159	1146	1099	1099
query71	419	308	266	266
query72	5136	3747	3879	3747
query73	646	774	356	356
query74	10620	9336	8793	8793
query75	3626	3181	2704	2704
query76	3589	1211	790	790
query77	773	376	288	288
query78	10262	10369	9657	9657
query79	3383	925	607	607
query80	721	545	455	455
query81	496	257	227	227
query82	235	118	88	88
query83	172	165	145	145
query84	284	103	88	88
query85	751	366	304	304
query86	353	328	297	297
query87	4337	4363	4280	4280
query88	3521	2421	2401	2401
query89	432	338	299	299
query90	2112	193	193	193
query91	140	138	114	114
query92	66	60	52	52
query93	2122	896	549	549
query94	655	428	303	303
query95	351	290	278	278
query96	499	623	285	285
query97	3156	3265	3161	3161
query98	225	205	202	202
query99	1534	1423	1309	1309
Total cold run time: 295331 ms
Total hot run time: 192526 ms

@doris-robot
Copy link

doris-robot commented Oct 9, 2025

ClickBench: Total hot run time: 28.47 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 267054d9c1529af4281deef5259e8bf46fe18f1a, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.02	0.03
query3	0.24	0.06	0.07
query4	1.61	0.10	0.11
query5	0.52	0.51	0.54
query6	1.14	0.73	0.72
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.50	0.48
query10	0.56	0.55	0.54
query11	0.14	0.10	0.10
query12	0.16	0.10	0.11
query13	0.61	0.60	0.60
query14	0.77	0.79	0.80
query15	0.84	0.82	0.82
query16	0.40	0.41	0.39
query17	1.11	1.03	1.04
query18	0.24	0.23	0.23
query19	1.82	1.79	1.87
query20	0.02	0.02	0.01
query21	15.40	0.98	0.59
query22	0.74	0.73	0.69
query23	15.13	1.49	0.54
query24	2.84	0.40	1.52
query25	0.17	0.11	0.16
query26	0.37	0.16	0.15
query27	0.04	0.04	0.05
query28	12.85	1.09	0.44
query29	12.59	3.97	3.31
query30	0.25	0.10	0.06
query31	2.81	0.61	0.41
query32	3.23	0.54	0.45
query33	3.08	3.04	3.07
query34	16.67	5.17	4.54
query35	4.62	4.59	4.54
query36	0.63	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 102.87 s
Total hot run time: 28.47 s

@freemandealer
Copy link
Contributor Author

freemandealer commented Oct 10, 2025

run p0

@freemandealer
Copy link
Contributor Author

freemandealer commented Oct 10, 2025

run cloud_p0

@freemandealer
Copy link
Contributor Author

freemandealer commented Oct 10, 2025

run cloud_p0

@freemandealer
Copy link
Contributor Author

freemandealer commented Oct 10, 2025

run p0

2 similar comments
@freemandealer
Copy link
Contributor Author

freemandealer commented Oct 11, 2025

run p0

@freemandealer
Copy link
Contributor Author

freemandealer commented Oct 11, 2025

run p0

@morrySnow morrySnow changed the title [fix](filecache) fix crash when clear file cache (#56170) branch-3.1: [fix](filecache) fix crash when clear file cache #56170 Oct 13, 2025
@morrySnow morrySnow merged commit a29ce5d into apache:branch-3.1 Oct 13, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@freemandealer @hello-stephen @doris-robot @gavinchou @morrySnow