Skip to content

branch-4.0: [fix](search) add restriction for search function #56706 #56707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 6, 2025
Merged

branch-4.0: [fix](search) add restriction for search function #56706 #56707

yiguolei merged 1 commit into from
Oct 6, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 5, 2025

Cherry-picked from #56706

@airborne12
[fix](search) add restriction for search function (#56706)
47e5574 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #56139 

Problem Summary:
This PR adds restrictions for the search() function to ensure it can
only be used in WHERE clauses on single-table OLAP scans. The
implementation includes validation rules that reject search() usage in
other contexts like SELECT projections, GROUP BY clauses, HAVING
clauses, and multi-table scenarios.
@github-actions github-actions bot requested a review from yiguolei as a code owner October 5, 2025 13:11
@Thearas
Copy link
Contributor

Thearas commented Oct 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Oct 5, 2025
@dataroaring dataroaring reopened this Oct 5, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 5, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 5, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Oct 5, 2025

ClickBench: Total hot run time: 29.82 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 47e557404a4ca8928b31183675862b22e7596267, data reload: true

query1	0.04	0.03	0.02
query2	0.11	0.03	0.04
query3	0.28	0.08	0.07
query4	1.74	0.10	0.10
query5	0.27	0.25	0.25
query6	1.25	0.64	0.63
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.63	0.51	0.52
query10	0.56	0.57	0.56
query11	0.18	0.11	0.11
query12	0.15	0.11	0.11
query13	0.64	0.61	0.63
query14	0.78	0.82	0.82
query15	0.88	0.85	0.83
query16	0.40	0.40	0.40
query17	1.06	1.03	1.05
query18	0.19	0.21	0.19
query19	1.92	1.78	1.75
query20	0.02	0.01	0.01
query21	15.47	0.90	0.57
query22	0.82	1.03	0.89
query23	15.02	1.36	0.57
query24	16.30	0.51	0.26
query25	0.23	0.04	0.07
query26	0.43	0.17	0.12
query27	0.05	0.04	0.04
query28	9.68	0.95	0.92
query29	12.73	3.91	3.22
query30	0.31	0.13	0.11
query31	3.00	0.57	0.38
query32	3.31	0.56	0.49
query33	3.11	3.01	3.11
query34	17.10	5.78	5.11
query35	5.07	5.14	5.15
query36	0.75	0.52	0.51
query37	0.10	0.07	0.06
query38	0.06	0.04	0.03
query39	0.03	0.03	0.03
query40	0.18	0.15	0.15
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 115.11 s
Total hot run time: 29.82 s

@yiguolei yiguolei merged commit 6e075ee into branch-4.0 Oct 6, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Thearas @hello-stephen @doris-robot @yiguolei @dataroaring @airborne12