Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2025

Cherry-picked from #56699

…56699)

Related PR: #56139

Problem Summary:

This PR fixes a bug in NULL bitmap handling for MATCH OR queries in
inverted index query. The bug was causing incorrect boolean logic
evaluation when combining TRUE and NULL values in OR operations.
@github-actions github-actions bot requested a review from yiguolei as a code owner October 4, 2025 04:32
@Thearas
Copy link
Contributor

Thearas commented Oct 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Oct 4, 2025
@dataroaring dataroaring reopened this Oct 4, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 4, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b954ee5b918524c15582bdf8a4d1d14124d8e0d7, data reload: true

query1	0.04	0.04	0.03
query2	0.11	0.04	0.03
query3	0.28	0.07	0.07
query4	1.74	0.11	0.11
query5	0.27	0.23	0.25
query6	1.25	0.64	0.64
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.62	0.52	0.51
query10	0.57	0.58	0.59
query11	0.18	0.10	0.12
query12	0.16	0.11	0.12
query13	0.64	0.61	0.62
query14	0.79	0.81	0.82
query15	0.88	0.86	0.83
query16	0.38	0.39	0.41
query17	1.06	1.04	1.07
query18	0.21	0.20	0.20
query19	1.97	1.76	1.81
query20	0.03	0.01	0.01
query21	15.44	0.93	0.59
query22	0.81	1.09	0.72
query23	15.15	1.37	0.64
query24	16.31	1.47	0.61
query25	2.27	0.39	0.20
query26	0.18	0.19	0.18
query27	0.20	0.20	0.19
query28	1.78	1.04	0.95
query29	12.73	3.93	3.24
query30	0.30	0.13	0.12
query31	2.99	0.58	0.38
query32	3.31	0.56	0.49
query33	2.99	3.18	3.08
query34	16.83	5.56	5.00
query35	5.09	5.11	5.06
query36	0.73	0.57	0.58
query37	0.10	0.08	0.07
query38	0.04	0.03	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.15
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.05	0.03	0.04
Total cold run time: 108.9 s
Total hot run time: 30.5 s

@yiguolei yiguolei merged commit 802fe6b into branch-4.0 Oct 4, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants